Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Museum items #2316

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

Updated Museum items #2316

wants to merge 2 commits into from

Conversation

Leomaradan
Copy link

Updated list of Museum Items, with all children and armor_to_id ids

DuckySoLucky
DuckySoLucky approved these changes Nov 10, 2024
View reviewed changes
Copy link
Member

@DuckySoLucky DuckySoLucky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, didn't test. probably should be rewritten to use items endpoint so there's no need for this. I might be able to do this next weekend but I'm not promising anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DuckySoLucky DuckySoLucky DuckySoLucky approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Leomaradan @DuckySoLucky @leomaradan2