Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add powers and stat tuning #1847

Open
wants to merge 12 commits into
base: development
Choose a base branch
from

Conversation

BrandonXLF
Copy link

Adds a new section that shows player's powers and their stats tuning

Closes: #1381

image

Copy link
Member

@DuckySoLucky DuckySoLucky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tested

Suggestion: add spacing before and after number.
+ 25 ❤️ Health instead of +25❤️Health

@BrandonXLF
Copy link
Author

lgtm, tested

Suggestion: add spacing before and after number. + 25 ❤️ Health instead of +25❤️Health

Done

@MartinNemi03 MartinNemi03 self-requested a review February 5, 2023 14:37
@MartinNemi03
Copy link
Member

MartinNemi03 commented Feb 19, 2023

Sorry for the delay, I'll resolve the conflict for you (since it doesn't seem that hard) along with starting the CI workflow and I'll go ahead with review.

Copy link
Member

@MartinNemi03 MartinNemi03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's an error that happens on certain profiles where the tuning object is present but doesn't have any data
(examples: Landon, vw14)

image

@github-actions github-actions bot added the has conflicts when a PR has conflicts label Mar 12, 2023
@BrandonXLF BrandonXLF changed the title feat: add Power & Stat Turning stats feat: add powers and stat tuning Apr 20, 2023
@github-actions github-actions bot removed the has conflicts when a PR has conflicts label Apr 20, 2023
@github-actions github-actions bot added the has conflicts when a PR has conflicts label Jun 11, 2023
@DuckySoLucky
Copy link
Member

Could you please resolve conflicts and add new reforges added in Rift update Click

@github-actions github-actions bot removed the has conflicts when a PR has conflicts label Jun 23, 2023
@BrandonXLF
Copy link
Author

Could you please resolve conflicts and add new reforges added in Rift update Click

Done

Copy link
Member

@metalcupcake5 metalcupcake5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and works fine, however it displays sanguisuge despite me not having unlocked it

@metalcupcake5
Copy link
Member

any reason why green is the chosen bg color?

@BrandonXLF
Copy link
Author

tested and works fine, however it displays sanguisuge despite me not having unlocked it

Looks like I didn't submit some code earlier, fixed.

any reason why green is the chosen bg color?

In-game powers use the uncommon (green) title colour.

@BrandonXLF BrandonXLF requested a review from metalcupcake5 July 17, 2023 03:39
@github-actions github-actions bot added the has conflicts when a PR has conflicts label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has conflicts when a PR has conflicts size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API accessory_bag_storage
4 participants