Changeable Max Stack Size for Items and Inventory #6698
Conversation
|
Should this PR also include changes to the |
The condition checks if the max stack size is more than 1, which to me it looks like it is fine as is, unless I’m missing something. |
Ye I have no idea what I was thinking when I looked at the condition earlier, looks so fine. Probably a result of no sleep tbh, my bad. |
| @Override | ||
| public Long convert(final ItemType i) { | ||
| return (long) i.getRandom().getMaxStackSize(); | ||
| public void change(Event event, @Nullable Object[] delta, ChangeMode mode) { |
There was a problem hiding this comment.
| public void change(Event event, @Nullable Object[] delta, ChangeMode mode) { | |
| public void change(Event event, Object @Nullable [] delta, ChangeMode mode) { |
| @@ -2,3 +2,49 @@ test "max stack": | |||
| assert max stack size of diamond sword is 1 with "diamond sword max stack size failed" | |||
| assert max stack size of bucket is 16 with "bucket max stack size failed" | |||
| assert max stack size of dirt is 64 with "dirt max stack size failed" | |||
|
|
|||
| test "max stack override - itemtype" when running minecraft "1.20.5": | |||
There was a problem hiding this comment.
I'd also like to see some tests of changing multiple items or category item types (all logs) at a time, with varying default sizes. Plus edge cases tests of null values on both sides.
Description
This PR adds support of changeable max stack size of inventories and the recently introduced
max stack sizeItemMeta in Minecraft 1.20.5.Javadocs:
Note
Using GitHub actions to test the attached test scripts due to Skript testing environment abruptly failing. My sincerely apologies for any bulk commits from fixing tests.
Target Minecraft Versions: Minecraft 1.20.5 (changeable itemstack max stack size)
Requirements: Spigot 1.20.5 (changeable max stack size ItemMeta)
Related Issues: #5020 (inventory)