Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Experience API Enhancement #6661

Open
wants to merge 4 commits into
base: dev/feature
Choose a base branch
from

Conversation

NotSoDelayed
Copy link
Contributor

@NotSoDelayed NotSoDelayed commented May 8, 2024

Description

This PR provides light enhancements to Skript's Experience API with:

  • Allowing Experience object into ExprTotalExperience (add 10 xp to player's total xp)
  • Add changers to Experience objects (set {-xp} to 10 xp, add 10 xp to {-xp}; results 20 xp)
    and top it off with some dusting in Experience class.

Target Minecraft Versions: any
Requirements: none
Related Issues: #6649

@NotSoDelayed
Copy link
Contributor Author

Tests will be added.

@sovdeeth sovdeeth added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label May 8, 2024
@NotSoDelayed NotSoDelayed requested a review from sovdeeth May 9, 2024 10:14
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests with an entity's xp would be nice, if we don't already have any.

@NotSoDelayed
Copy link
Contributor Author

Some tests with an entity's xp would be nice, if we don't already have any.

I only recalled Player have XP. How does one do it with non-player entities?

@sovdeeth
Copy link
Member

Some tests with an entity's xp would be nice, if we don't already have any.

I only recalled Player have XP. How does one do it with non-player entities?

ExperienceOrb, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants