Feature/adding911 flavors #292
Conversation
rabehaja
requested review from
bplasmeijer,
jeanfrancoislarente,
joostmeijles and
pbering
as code owners
|
---TESTING--- |
bplasmeijer
added
question
|
please review changes @rabehaja |
|
@bplasmeijer I will check it in tonight :) |
|
Rebase is done |
|
Changes have been implemented, rebase executed. Please check |
adding the missing files reset the default value to 9.3.0 remove comments moved the sitecore-xm folder to the proper folder to follow general structure Update .env removed my container name removed xc datafolders, updated readme with the correct values, updated the changelog, updated contributor list, removed duplicate compose file updating the images list adding the missing files reset the default value to 9.3.0 remove comments moved the sitecore-xm folder to the proper folder to follow general structure Update .env removed my container name adding the missing files reset the default value to 9.3.0 remove comments moved the sitecore-xm folder to the proper folder to follow general structure Update .env removed my container name removed xc datafolders, updated readme with the correct values, updated the changelog, updated contributor list, removed duplicate compose file updating the images list adding the missing files reset the default value to 9.3.0 remove comments moved the sitecore-xm folder to the proper folder to follow general structure Update .env removed my container name removed xc datafolders, updated readme with the correct values, updated the changelog, updated contributor list, removed duplicate compose file running the formatting standard for workspace adding the 9.1.1 images for SXA, JSS, SPE adding the missing files reset the default value to 9.3.0 remove comments moved the sitecore-xm folder to the proper folder to follow general structure Update .env removed my container name removed xc datafolders, updated readme with the correct values, updated the changelog, updated contributor list, removed duplicate compose file adding the 9.1.1 images for SXA, JSS, SPE adding the missing files reset the default value to 9.3.0 remove comments moved the sitecore-xm folder to the proper folder to follow general structure Update .env removed my container name removed xc datafolders, updated readme with the correct values, updated the changelog, updated contributor list, removed duplicate compose file adding the vs folder to the git ignore
rabehaja
force-pushed
the
feature/adding911_flavors
branch
from
9eebb60
to
93c35fb
Compare
|
Hi @rabehaja Sorry for the wait, we do have a new structure in place on docker-images, if you want to rebase, and apply to the new folder structure we can then accept your PR after QA. Otherwise close PR. Thanks |
|
Hi, I will make a rebase on the main branch and re submit |
|
Hello, I am working on 9.1.0 and wondering if this PR was going to be merged? If so I will conform with it. |
At this moment it's a massive change on legacy versions. If someone wanted to pick up the rebase and submit I will commit to testing and running it. |
|
Seems like a lot of formatting changes across many versions. I wonder if it should only add support for 9.1.1? |
That’s definitely acceptable |
|
@rabehaja did you want collaborate on a new PR that brings support for 9.1.x? we can start fresh and ensure that we don't pushing in any changes to files that impact other versions. |
|
@gravypower let's collab :) |
|
@gravypower @rabehaja Please note the current issue #388 in the repo where sitecore-tags.md is marked as modified even when it isn't. It's a major PITA to work with if you mistakenly add it to one of your commits (since it's not supposed to be modified by the community). Upon initial checkout, and often during a pull, etc. you will see the issue. To clear it up locally, ensure you have no other pending changes (stash them, except for sitecore-tags.md file if you do) and run: git rm .gitattributes
git add -A
git reset --hardThen you can carry on with your other commands/action. |
|
Great @rabehaja :) Ah that's why I could not revert that file, thanks for the tip @jeanfrancoislarente. |
|
@rabehaja I have moved your changes (that I can see) here https://github.com/gravypower/docker-images. Are you happy to work from this fork? |
Added some SXA, JSS, SPE variants for the Sitecore 9.1.1 docker images.