Skip to content

Commit

Permalink
Set release instead of source&target
Browse files Browse the repository at this point in the history
  • Loading branch information
liry committed Nov 1, 2022
1 parent 217322a commit 8fc0909
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 6 deletions.
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ GNU General Public License Version 3. See [LICENSE](LICENSE)
Contains images from Silk Icon Set v.1.3 (http://www.famfamfam.com/lab/icons/silk/)

## Development

One needs JDK 11+ for building (requirement of some dependencies). Target release is still set to Java 8 (so resulting
jar should be runnable under JRE 8).

#### Build runnable JAR including all dependencies
```
mvn clean package assembly:single
Expand Down
10 changes: 6 additions & 4 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
</contributors>

<properties>
<targetJdk>1.8</targetJdk>
<targetJavaRelease>8</targetJavaRelease>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
</properties>
Expand All @@ -70,10 +70,12 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.1</version>
<version>3.10.1</version>
<configuration>
<source>${targetJdk}</source>
<target>${targetJdk}</target>
<release>${targetJavaRelease}</release>
<showDeprecation>true</showDeprecation>
<showWarnings>true</showWarnings>
<fork>true</fork>
</configuration>
</plugin>
<plugin>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@

import org.testng.annotations.Test;

import static org.testng.Assert.*;

public class UploadWindowTest {

// just for manual UI testing
Expand Down

0 comments on commit 8fc0909

Please sign in to comment.