GBDK-2020 4.1.x update + minor optimizations #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The game crashes, but it's now at least able to be compiled with gbdk-2020.
|
I've kind of given up hope in him responding :/ I guess he just isn't interested. |
|
@SimonLarsen Sorry to directly ping you like this, but I wanted to reach out again to see if you still have any interest in having this merged. If not, then we would appreciate you letting us know so we can just close this. Totally up to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if you're still interested, but this set of patches makes the game compile with a vanilla GBDK-2020 4.1.1 (latest version) setup. I've also introduced some minor optimizations - some to adapt to SDCC 4.2.x's new calling convention, some just "driving by". The game seems to function fully correctly in testing.