-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] [MER-4068] Reimplement user invite functionality #5322
Open
nicocirio
wants to merge
85
commits into
master
Choose a base branch
from
MER-4068-reimplement-user-and-author-invite-functionality
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[FEATURE] [MER-4068] Reimplement user invite functionality #5322
nicocirio
wants to merge
85
commits into
master
from
MER-4068-reimplement-user-and-author-invite-functionality
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x if it doesnt already exist (#5181)
convert author accounts remove Pow dependency
add settings pages
separate live_socket_id for user and author accounts
add auth provider links to other login pages
…igrate-to-phx-auth-v29
remove remaining references to pow
…-and-author-invite-functionality
…n overview-student tab
…send email invitations
…ontroller + create new route for that post action
…ted_by_id (in the future an invitation could be sent by an author)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to the ticket
As discussed in the ticket, this PR also introduced the
:pending_confirmation
and:rejected
statuses for and enrollment, to allow the user to decide what to do with an invitation (in the previous version the user was enrolled and the email invitation ended up being an information email)So, the student's overview page (in the instructor dashboard) was expanded to allow the instructor to filter by these two new values.
On the other hand, now the student workspace won't show the course until the student ends up accepting the invitation (in a future iteration we might want to show a
pending confirmation
course as "grayed" with a link to the UserInvite liveview)A non-existing user invitation flow
Screen.Recording.2024-12-20.at.7.09.27.PM.mov
An existing user invitation flow (not logged in -> password must be provided)
Screen.Recording.2024-12-20.at.7.11.24.PM.mov
An existing user invitation flow (logged in with the same account as the invitation)
Since the user is already logged in, the user invitation is confirmed and the user gets redirected to the course as soon as it clicks the "Accept" button
Screen.Recording.2024-12-20.at.7.17.39.PM.mov
An existing user invitation flow (logged in with a different account than the invitation)
The user sees a warning and will be logged in with the account corresponding to the invitation
Screen.Recording.2024-12-20.at.7.24.57.PM.mov
Rejecting an invitation flow
Screen.Recording.2024-12-20.at.7.13.33.PM.mov
An already rejected invitation
An already accepted invitation
A non-existing invitation
Background color matches the invitation role
Student invitation
Instructor invitation