Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: textTheme for dart 3.4.0 and flutter 3.22.0 #445

Closed

Conversation

ziqq
Copy link

@ziqq ziqq commented May 20, 2024

Description

image

@Frezyx
Copy link

Frezyx commented May 21, 2024

Hello @BirjuVachhani !
Please check this PR, we can't build our applications with new Flutter version ⚠️

@ziqq
Copy link
Author

ziqq commented May 21, 2024

Hello @Frezyx,

I fixed it, u can try it again.

image

@Frezyx
Copy link

Frezyx commented May 21, 2024

@ziqq Hello bro!
You misunderstood me, your fork works for me.
I want ping package maintainer to merge this PR in the main package branch so that I don't use the fork.

@chandrabezzo
Copy link
Contributor

chandrabezzo commented May 22, 2024

Hi @ziqq you duplicatie #433 , CMIIW @aditya-css

@chandrabezzo
Copy link
Contributor

Please see #433 @Frezyx

@ziqq
Copy link
Author

ziqq commented May 22, 2024

Hi @ziqq you duplicatie #433 , CMIIW @aditya-css

Hi @chandrabezzo, yes it is, but i fix android config to

@chandrabezzo
Copy link
Contributor

@ziqq your fix on Android doesn't need because just related on example.

@chandrabezzo
Copy link
Contributor

We urgently need to fix on library issue not on example issue. The example still runnable on 3.22

@ziqq ziqq closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants