bugfix - 228 - add setReleaseMode method for manage player state #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ujas-m-simformsolutions
requested changes
Feb 20, 2024
lib/src/base/utils.dart
Outdated
| /// This enum is meant to be used as a parameter of setReleaseMode method. | ||
| /// | ||
| /// It represents the behavior of AudioPlayer when an audio is finished or stopped. | ||
| enum ReleaseMode{ |
There was a problem hiding this comment.
Let's not change the name of the enum because then it will be a bigger breaking change
| fun setReleaseMode(result: MethodChannel.Result, releaseModeType : Int?){ | ||
| try{ | ||
| releaseModeType?.let { | ||
| when (releaseModeType) { |
There was a problem hiding this comment.
This looks much better than previous
There was a problem hiding this comment.
Thank you
Update the code as per reviewer suggestion
himanshuGandhiSimform
force-pushed
the
fix/228/add_setReleaseMode
branch
from
2309e6f
to
9dab1fd
Compare
ujas-m-simformsolutions
requested changes
Mar 14, 2024
| ///Release all resources, just like calling release method. | ||
| /// | ||
| /// In Android, the media player is quite resource-intensive, and this will | ||
| /// let it go. Data will be buffered again when needed (if it's a remote file, |
There was a problem hiding this comment.
We don't support remote files so remove it.
There was a problem hiding this comment.
Or even better can replace this whole docs with ours
| ///Set the release Mode. | ||
| /// | ||
| /// Check[FinishMode]'s doc to understand the difference between the modes. | ||
| Future<void> setReleaseMode(FinishMode finishMode)async{ |
There was a problem hiding this comment.
Make named parameter with default value and format
hemantbeast
added a commit
to hemantbeast/audio_waveforms
that referenced
this pull request
May 28, 2024
…eMode method for manage player state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BugFix - 228 - Add setRelease Mode as per the requirement