Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setReleaseMode #228

Open
moshOntong-IT opened this issue Jun 30, 2023 · 2 comments · May be fixed by #269
Open

Add setReleaseMode #228

moshOntong-IT opened this issue Jun 30, 2023 · 2 comments · May be fixed by #269
Labels
enhancement New feature or request

Comments

@moshOntong-IT
Copy link

Is your feature request related to a problem? Please describe.
We should add a method for finishMode something like in audio player has asetReleaseMode

Describe the solution you'd like
We should option that the user will have choices to choose if it enable the loop mode or not
@moshOntong-IT moshOntong-IT added the enhancement New feature or request label Jun 30, 2023
@Ujas-Majithiya
Copy link
Collaborator

So your proposal is to add a method to set release mode instead of setting it from startPlayer right?

@moshOntong-IT
Copy link
Author

yup that is right we should remove the finishMode parameter in startPlayer, it is prefer to create a setReleaseMode

@himanshuGandhiSimform himanshuGandhiSimform linked a pull request Feb 20, 2024 that will close this issue
bugfix - 228 - add setReleaseMode method for manage player state #269
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@Ujas-Majithiya @moshOntong-IT