-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output file: long string name causes wrong format #100
Labels
Comments
While @chlookaburra and I were looking at the code, we noticed two occasions where we're using a fixed-size buffer: svZeroDSolver/src/solve/csv_writer.cpp Lines 50 to 52 in 7c722a5
svZeroDSolver/src/solve/csv_writer.cpp Lines 182 to 184 in 7c722a5
I could see a full buffer causing this problem (I don't know if those sizes are hard-coded for performance). As a first step, try increasing them and see if that solves the problem. If yes, we could either dynamically allocate the size (if that doesn't reduce performance) or throw an error if things would be written incorrectly. |
1 task
Output should use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
If the string name of a blood vessel is too long, then it will append to the pressure_out column, instead of at the start of a new row.
See the attached file, where the first row has the usual time, flow_in, flow_out, pressure_in, pressure_out columns. However, the second and third rows have the name of the next blood vessel in the pressure_out column, which can cut off the value of pressure_out (as in the third row).
Reproduction
One could try naming a blood vessel "RightCommonCarotidArtery," which will reproduce this result.
Expected behavior
We would like svZeroDSolver to throw an error if we enter a blood vessel name that is too long or accept long strings.
Additional context
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: