Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output .csv file truncates time steps for a large (>93) vessel system #105

Closed
1 task done
chlookaburra opened this issue Mar 2, 2024 · 3 comments
Closed
1 task done
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@chlookaburra
Copy link

chlookaburra commented Mar 2, 2024

Description

I am running a 116-vessel system with 1000 time steps and 10 cardiac cycles, and outputting the final cardiac cycle ("output_all_cycles": false).

The issue is that, starting with the 93th vessel, only 984 time steps are printed in the .csv file. Before that, 1000 time steps are printed.

results_bug_length.csv

Reproduction

test0d_no_calib_refined.json

Create any >93 vessel system and set the following simulation parameters:

"simulation_parameters": { "number_of_cardiac_cycles": 10, "number_of_time_pts_per_cardiac_cycle": 1000, "output_all_cycles": false },

Expected behavior

I was expecting to see a .csv file with 1000 time steps per vessel.

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct and Contributing Guidelines
@chlookaburra chlookaburra added the bug Something isn't working label Mar 2, 2024
@menon-karthik
Copy link
Member

@natalia-rubio Any chance this is related to #100?

@menon-karthik menon-karthik added the good first issue Good for newcomers label Apr 29, 2024
@kharold23
Copy link
Contributor

I ran the simulation with the attached json, and the output isn't truncated for me.
results.csv

I'm using MacOS and the newest version of sv0D... What operating system did you run it on? (There have been system-specific issues before)

@chlookaburra
Copy link
Author

I ran it on a MacOS when this issue was posted. I just checked again—and it works with the newest version of svZeroDSolver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants