Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ability for solver to account for leakage in the vessel, as well as relevant test cases for validation. #109

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Added ability for solver to account for leakage in the vessel, as well as relevant test cases for validation. #109

wants to merge 13 commits into from

Commits on Nov 11, 2023

  1. added ability for outflow terms to be specified in the input file

    @JRao-rgb
    JRao-rgb committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    f21006d View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. fixed linear solution. Now to go back add fix file I/O again...

    @JRao-rgb
    JRao-rgb committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    05be02d View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. added new testing files to test the linear material as well as with o… 

    …utflow
    @JRao-rgb
    JRao-rgb committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    8dce291 View commit details
    Browse the repository at this point in the history

  2. pytest changes. Not sure what they are. I didn't touch anything I jus… 

    …t ran pytest -v lol
    @JRao-rgb
    JRao-rgb committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    4fbf0cb View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. fixed small error in test_integration.py that repeated one of the tests

    @JRao-rgb
    JRao-rgb committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    436cb9e View commit details
    Browse the repository at this point in the history

  2. ok added build_skyline to gitignore so hopefully that will not be upl… 

    …oaded again
    @JRao-rgb
    JRao-rgb committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    5d99fb3 View commit details
    Browse the repository at this point in the history

  3. cleaning up the build directories so hopefully they will not be commi… 

    …tted
    @JRao-rgb
    JRao-rgb committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    ca60b52 View commit details
    Browse the repository at this point in the history

  4. removed (cleaned up) all my debug statements, so hopefully it shouldn… 

    …'t print things like crazy
    @JRao-rgb
    JRao-rgb committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    2b37da0 View commit details
    Browse the repository at this point in the history

  5. added documentation for the new test cases related to outflow

    @JRao-rgb
    JRao-rgb committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    d78d0de View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. there's been another issue: for some reason, the code is taking a lon… 

    …g time to converge for L_P = 1e-4, even though PREVIOUSLY it did not have this issue. I can't for the life of me remember what changed to get us here. I'm just committing this so I can switch the branch to master and then make a new branch where I hard-code in the outflow and see what happens. Break the least amount of shit and see what stays broken, right?
    @JRao-rgb
    JRao-rgb committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    908ae08 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. got rid of the return statement issue. Only committing rn so I can ch… 

    …ange the branch and start more systemmatically testing for what is making the convergence issue so shit. Stay tuned.
    @JRao-rgb
    JRao-rgb committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    08e1e09 View commit details
    Browse the repository at this point in the history

  2. NOW I fixed the return issue. Ugh. I feel old.

    @JRao-rgb
    JRao-rgb committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    d8ae672 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2023

  1. tried some things. Did not work. Going to try to make a separate bran… 

    …ch with modified file I/O to look into convergence issues.
    @JRao-rgb
    JRao-rgb committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    4fd02c4 View commit details
    Browse the repository at this point in the history