Improve fluid perf 79 #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SIplus into Improve-fluid-perf_79
MatteoSalvador
requested changes
Aug 30, 2023
There was a problem hiding this comment.
Thanks @ktbolt! Just left a couple of comments.
For the rest, it looks fine to me.
MatteoSalvador
approved these changes
Aug 30, 2023
|
Approved @ktbolt! I think there are a few conflicts in |
mrp089
referenced
this pull request
in mrp089/svFSIplus_old
Nov 30, 2023
* Replace Array objects with array. * Replace more Array. * Replace Array objects with arrays. * Disable using raw data for arrays in fsils_spar_mul_sv. * Enable using raw data in fsils_spar_mul_sv. * Replace the Array3.slice() calls with Array3.rslice(). * Replace slice with rslice. * Fix problem with using rcol(). * Clean up prototype code. * Clean up prototype code. * Remove using raw pointers, doesn't seem to matter much.
mrp089
referenced
this pull request
in mrp089/svFSIplus_old
Nov 30, 2023
* Replace Array objects with array. * Replace more Array. * Replace Array objects with arrays. * Disable using raw data for arrays in fsils_spar_mul_sv. * Enable using raw data in fsils_spar_mul_sv. * Replace the Array3.slice() calls with Array3.rslice(). * Replace slice with rslice. * Fix problem with using rcol(). * Clean up prototype code. * Clean up prototype code. * Remove using raw pointers, doesn't seem to matter much.
mrp089
referenced
this pull request
in mrp089/svFSIplus_old
Nov 30, 2023
* Replace Array objects with array. * Replace more Array. * Replace Array objects with arrays. * Disable using raw data for arrays in fsils_spar_mul_sv. * Enable using raw data in fsils_spar_mul_sv. * Replace the Array3.slice() calls with Array3.rslice(). * Replace slice with rslice. * Fix problem with using rcol(). * Clean up prototype code. * Clean up prototype code. * Remove using raw pointers, doesn't seem to matter much.
mrp089
referenced
this pull request
in mrp089/svFSIplus_old
Nov 30, 2023
* Replace Array objects with array. * Replace more Array. * Replace Array objects with arrays. * Disable using raw data for arrays in fsils_spar_mul_sv. * Enable using raw data in fsils_spar_mul_sv. * Replace the Array3.slice() calls with Array3.rslice(). * Replace slice with rslice. * Fix problem with using rcol(). * Clean up prototype code. * Clean up prototype code. * Remove using raw pointers, doesn't seem to matter much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some changes for improved performance. The main changes are using the
Array.rslice()method and C++ arrays instead ofArrayandVectorobjects.