Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solid viscosity update #286

Merged
merged 22 commits into from
Oct 8, 2024
Merged

Solid viscosity update #286

merged 22 commits into from
Oct 8, 2024

Conversation

aabrown100-git
Copy link
Collaborator

@aabrown100-git aabrown100-git commented Oct 5, 2024 •
edited
Loading

Current situation

#273

Release Notes

  • Implement pseudo-potential viscosity model for solid mechanics
  • Reorganize solid viscosity implementation to allow the user to choose between Newtonian or Potential model. Also, internally distinguish between solid and fluid viscosity parameters
  • For Newtonian model, remove viscosity-based stabilization in ustruct

Documentation

Documentation changes proposed in this PR to simvascular.github.io

Testing

Add integration tests for each solid viscosity model, for both struct and ustruct.

Code of Conduct & Contributing Guidelines

aabrown100-git and others added 21 commits September 9, 2024 12:12
@aabrown100-git
Solid viscosity update and restructuring first pass. Added preliminar…
aad683e 
…y viscosity test. Compiles and runs, but all existing struct and ustruct tests fail. Also, fluid/carreau-yasuda 3-procs fails.
@aabrown100-git
Merge branch 'SimVascular:main' into solid_viscosity_update
785dd34
@aabrown100-git
Add useful comments
603bcb1
@aabrown100-git
Update comments for solid visc models
ddc1dfb
@aabrown100-git
Updating solid viscosity for ustruct. Removing solid viscosity stabil…
03d71c2 
…ization in ustruct_xd_c() following Vijay's svFSI fork
@aabrown100-git
Solid viscosity update for struct_2d(). Cleanup comments in struct_3d…
6936119 
…_carray()
@aabrown100-git
Adding back viscosity-based stabilization in ustruct_xd_c(). PROBABLY…
864f51d 
… REMOVE LATER. Also, print solid_viscosity parameters
@aabrown100-git
Modifying viscosity test case and documentation
84a492e
@aabrown100-git
Removing viscosity-based stabilization in ustruct_xd_c(). According t…
05ff4b0 
…o Vijay, not important. Not included in Vijay's fork. This causes 2 ustruct tests (tensile_adventitia_HGO and LV_Guccione_active) to fail, because due to their larger momentum stabilization terms, they are slightly impacted by viscosity-based stabilization.
@aabrown100-git
Potential viscosity bug fix (very important for convergence)
a824f50
@aabrown100-git
Minor bug fix in Newtonian tangent. Doesn't seem to improve convergen…
3d5000d 
…ce. Probably still another bug in Newtonian tangent.
@aabrown100-git
Updating Newtonian viscosity test case, adding Potential viscosity te…
466f9e6 
…st case
@aabrown100-git
Adding note about likely error in Newtonian tangent
0d1dc5a
@aabrown100-git
Add ustruct viscosity tests, update load profile description in READMEs
e6bc611
@aabrown100-git
Merge branch 'main' of https://github.com/SimVascular/svFSIplus into …
82418b0 
…solid_viscosity_update
@aabrown100-git
Merge branch 'SimVascular:main' into solid_viscosity_update
73e58f0
@aabrown100-git
Change input file to take only "Viscosity". Code determines if Solid_…
0f677f5 
…viscosity or Fluid_viscosity from context
@aabrown100-git
Replace raw strings with EquationType physics types. Add CMM and stok…
4557b07 
…es to supported physics for fluid viscosity (integration tests now pass). Fixed small typo in pipe_3d_petsc input file viscosity definition
@aabrown100-git
Merge branch 'SimVascular:main' into solid_viscosity_update
22d402c
@aabrown100-git
Merge branch 'SimVascular:main' into solid_viscosity_update
e9621bd
@aabrown100-git
Removing references to old solid_viscosity
1e58948
@aabrown100-git aabrown100-git mentioned this pull request Oct 5, 2024
Merged
1 task
@aabrown100-git aabrown100-git assigned ktbolt and aabrown100-git and unassigned ktbolt Oct 5, 2024
ktbolt
ktbolt approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@ktbolt ktbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@aabrown100-git aabrown100-git merged commit f754c50 into SimVascular:main Oct 8, 2024
5 checks passed
@aabrown100-git aabrown100-git deleted the solid_viscosity_update branch October 8, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktbolt ktbolt ktbolt approved these changes

Assignees

@aabrown100-git aabrown100-git

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aabrown100-git @ktbolt