Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svZeroD Solver Coupling Interface #217

Merged
merged 26 commits into from
Jun 19, 2024

Conversation

kharold23
Copy link
Contributor

svZeroD Solver Coupling Interface

Current situation

#70

Release Notes

  • Added integration with svZeroD solver to allow for 3D-0D coupling with sv0D
  • Added test cases in fluid, struct, and ustruct
  • Added sv0D build/compiling to the workflows to allow tests to run

Documentation

Please ensure that you properly document any additions.

Testing

Please ensure that the PR meets the testing requirements set by GitHub Actions.

In addition, please ensure all modified and new code is covered by tests.

Code of Conduct & Contributing Guidelines

Copy link
Collaborator

@MatteoSalvador MatteoSalvador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kharold23, great job!

I see there are only a few issues on Ubuntu and MacOS for continuous integration. For the former, you can have a chat with @dcodoni so he can properly integrate cloning and building svZeroDSolver into his docker containers (feel free to explore other/different options). For the latter, it seems that the genBC related tests actually fail. Probably we should just upgrade them to svZeroDSolver without changing the reference solution (which should remain the same).

@kharold23
Copy link
Contributor Author

Yep! I'm working with him now! Also, I have to check into the genBC tests, because they were working before I rebased my code.

@dcodoni
Copy link
Contributor

dcodoni commented Jun 18, 2024

Good job @kharold23!
I have no comments from my part!

@kharold23
Copy link
Contributor Author

Ok, I got all of the test cases working again! (I had to add the "Linear Algebra" element to the xml files and then decrease the tolerance for the ustruct case)

@MatteoSalvador MatteoSalvador merged commit e675676 into SimVascular:main Jun 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants