-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
High order element face mesh fails 205 #206
High order element face mesh fails 205 #206
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #206 +/- ##
==========================================
- Coverage 63.12% 62.79% -0.34%
==========================================
Files 105 103 -2
Lines 27424 27213 -211
==========================================
- Hits 17312 17088 -224
- Misses 10112 10125 +13 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix high order element face mesh fails 205
Add a fluid test case for tet10 elements.
@wgyang thanks for adding this test! Unfortunately the pipeline is currently failing with the error |
@MatteoSalvador Sorry about that. I will fix it. |
Fix an error associated with importing conftest.py.
@wgyang I have changed the workflow for tests on Ubuntu to a Docker-based framework. If you pull the current |
Thank you @MatteoSalvador! Will do. |
Incorporate recent updates on test tolerance and continuous integration
Fix integration test errors
@ktbolt I noticed that this PR has been closed (and the corresponding branch deleted) before merging it. |
@MatteoSalvador Did this not get merged by @wgyang. |
@MatteoSalvador Yes, I agree. There were a few compatibility issues with a specific version of the operating system. |
Thanks @wgyang! Unfortunately, I cannot reopen this PR because the original branch has been deleted. Could you replicate all the features of this PR starting from the current main of svFSIplus? Otherwise I can of course help you with this! |
@MatteoSalvador I recreated a pull request in order to merge the fix for the high order element test case. |
Thanks @wgyang, the PR looks great! |
CFD simulations were failing with 10-noded Tets, fixed several bugs. See #205.
The PR has a bit of noise from adding some debugging statements and replacing some incorrect array initialization statements.