Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on macOS 14 #196

Closed
wants to merge 21 commits into from
Closed

Conversation

mrp089
Copy link
Member

@mrp089 mrp089 commented Feb 22, 2024

Current situation

Closes #176. Draft for now to run pipeline

Release Notes

Adds macOS 14 and Apple Silicon runner for GitHub Actions.

Documentation

None

Testing

Hopefully macOS 14 Action will run on GitHub

Code of Conduct & Contributing Guidelines

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.50%. Comparing base (b99e12e) to head (206c806).
Report is 1 commits behind head on main.

❗ Current head 206c806 differs from pull request most recent head 840a439. Consider uploading reports for the commit 840a439 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #196   +/-   ##
=======================================
  Coverage   57.50%   57.50%           
=======================================
  Files         103      103           
  Lines       26964    26964           
=======================================
  Hits        15505    15505           
  Misses      11459    11459           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrp089 mrp089 changed the title Test apple silicon Test on macOS 14 Feb 23, 2024
@mrp089
Copy link
Member Author

mrp089 commented Feb 23, 2024

@aabrown100-git, I'm trying to build and test on macos-14 (currently we only have macos-12). However, I keep getting errors that HDF5 or VTK are not found. The build worked in 3ee6c26. However, when I change something DOWNSTREAM of the build, like the Python calls in Install test dependencies (840a439), it fails. Have you had similar issues?

@aabrown100-git
Copy link
Collaborator

aabrown100-git commented Feb 24, 2024

That is really bizarre. I’m really not sure, the only thing I can think of is this. Apparently, these GitHub Mac environments come with some preinstalled libraries, using Homebrew and maybe other package managers. Maybe you’re not guaranteed to have certain libraries available, like it’s random based on what machine you get? Sounds unlikely but just putting it out there. Also, I checked the logs for the commit that worked (3ee6c26), and it looks like the HDF5 that was found was not found in the Homebrew directories (most of the other packages have paths like opt/homebrew/…).


-- Found HDF5: hdf5-shared (found version "1.14.3") found components: C HL

@mrp089
Copy link
Member Author

mrp089 commented Mar 6, 2024

Thanks for your help, @aabrown100-git! I'm closing this for now. Someone can revive it later maybe once the macos-14 GitHub runner is more established.

@mrp089 mrp089 closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test on Apple Silicon
2 participants