Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Holzapfel material model and test #164

Merged

Conversation

aabrown100-git
Copy link
Collaborator

@aabrown100-git aabrown100-git commented Dec 13, 2023

Current situation

svFSIPlus does not correctly process the Holzapfel material model for struct/ustruct. Modifications were proposed by @ktbolt in PR #131, but this was closed amid repo restructuring described here #149. Also, the original PR did not include a test case for the Holzapfel model.

Release Notes

  • Minor modifications to process the Holzapfel material model, copied from the original PR Add processing the Holzapfel material model. #131
  • New test case for Holzapfel model called LV_Holzapfel_passive, which simulates passive inflation of a left ventricle with the Holzapfel model.

Code of Conduct & Contributing Guidelines

@aabrown100-git
Copy link
Collaborator Author

@MatteoSalvador Please review when you get a chance. (I don't seem to have the ability to officially assign you to this pull request)

Copy link
Collaborator

@MatteoSalvador MatteoSalvador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aabrown100-git! This looks good to me

@MatteoSalvador MatteoSalvador merged commit 90c27b8 into SimVascular:main Dec 13, 2023
5 checks passed
@aabrown100-git aabrown100-git deleted the Holzapfel_material_model_new branch December 13, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants