-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding support for higher-order elements #154
adding support for higher-order elements #154
Conversation
…, and biquadtratic quad
@zasexton Have you tested for all higher-order elements? |
You can switch on this test, which should give you 6-noded triangles: main...mrp089:svFSIplus:test_P2_145 For 10-noded tetrahedrons, you can add this additional mesh to the existing |
This is the list of
I will add this support for the 27-node element and run the test case on my local machine today. I'll include a comparison of the results for the mentioned element types above in this discussion to verify the code. |
Awesome, @zasexton! Since you're running those already, can you add them to the |
@mrp089 I can as long as I don't mess up the |
No worries, you can't mess it up more than I have done! Ensure you have git lfs installed on your local machine. In addition, you need to run We will have a look over the PR before we merge it! |
|
It will automatically track all the file extensions specified here (basically everything in here that is not code). These are then handled directly via GitHub and not added to the repository itself, which will only contain a hash. |
For the tests themselves, please have a look at the existing ones. Add them to a new folder
from the |
Okay! You're right this seems very straightforward. I'll let you know if I run into any problems. One last question for both @mrp089 and @ktbolt : |
Good point! We default to one time step; some tests run five time steps. We usually do the following:
|
Thanks @zasexton for the great work you did! |
Comparison between
|
@zasexton There is definitely a bug in computing Be careful comparing results from the current svFSI code, the svFSIplus code was converted from svFSI commit e258b9f. |
For the Similarly for I'll double check all of the simulation parameters to see if I have any differences in the simulation setup/assumptions. Overall, values which are computed from the simulation (e.g. |
@ktbolt I've been comparing the |
Added final support for |
…K_TRIQUADRATIC_HEXAHEDRON #114
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
In response to face area errors for higher-order elements this branch and draft pull request are being made. This addresses specific issues raised by @ktbolt in #114
Current situation
See #114
Release Notes
Added support for the following higher order elements:
Documentation
Relevant documentation extends on previous
ordering
attributes for linear elements.Testing
Additional tests will need to be carried over from
svFSI-Tests
which were created for quadratic elements. This draft pull request was not for migrating these test cases. Perhaps the minimum necessary tests can be selected for this draft pull request before proceeding to an official pull request.Code of Conduct & Contributing Guidelines