Holzapfel material model and test #151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* rough first doxygen * add workflow file * update paths * convert existing comments to Doxygen * fix build * manually build Doxygen * change path * print paths * echo * add svFSILS * add checkout to actions * include markdown files in Doxygen
Co-authored-by: Matteo Salvador <[email protected]>
Co-authored-by: Elena Martinez <[email protected]>
… guccione active) (#113)
* Add a CMM test case. Results are consistent with svFSI output. Prestress examples will be added. * Use a linear solver setting without Trilinos for the cmm inflation test case. * Remove .inp files in the cmm test case. Reduce the number of time steps for the inflation procedure. * Add prestress examples for the cmm test case. --------- Co-authored-by: Martin R. Pfaller <[email protected]>
* Expose tau_fi and tau_si from BO in the XML interface * Tests
* adding darcy equation * darcy equation can be built but generates a trivially zero solution * commenting files to find mesh indexing error * correcting gN, gE, and IEN after reading meshes * removing IEN resetting in vtk_xml.cpp since this functionality is moved into load_msh.cpp * adding general parameters for unsteady darcy problem * added final version of the hash map for gN, gE, and IEN setting for face meshes * adding binary mask permutation for non-tet elements (#114) * adding boundary node counter-clockwise ordering to element matching (#114) * completed 2D darcy general model formulation for (#71) * adding scientific notation and 16 precision to global node matching (#114) * Revert "Merge branch 'Tissue-perfusion-model-#71' into 0-indexed-meshes(#114)" This reverts commit 7cbf43a0b21cdb5706b5292f8c5f62cd8b0d4070, reversing changes made to 7a97ef62e0b7b2e1d380230b081f62e508dce471. * encapsulating hash map generation (#114) * remove commented lines performing un-encapsulated hash map generation * adding error checking for duplicate nodes during hash map generation (#114) --------- Co-authored-by: Dave Parker <[email protected]>
* Add gklib and copy over new code. * Set int and real widths to 32, setting to 64 does not work. * Add some READMEs.
* modify python * move cep * move cmm * move fluid * move fsi * move heats * mvoe stokes * move struct * move ustruct * move cep * move cep * fix move * fix name * fix cmm * fix run_with_reference call * fix relative paths
* Fix indexing bug. * Fix indexing problem (again). * Modify the calls to all_fun::integ() functions to pass in an array's 0-based index range. --------- Co-authored-by: Matteo Salvador <[email protected]>
Co-authored-by: Matteo Salvador <[email protected]>
Copy commits to process Holzapfel material model from Dave, originally in SimVascular/svFSIplus#131
Co-authored-by: Elena Martinez <[email protected]>
MatteoSalvador
requested changes
Dec 8, 2023
There was a problem hiding this comment.
Thanks @aabrown100-git!
I apologize for the late review but I did not receive a notification.
Next time, assign one/multiple reviewers for the PR :)
It looks good to me. However, before merging, you should remove the files that are not strictly necessary to run the tests (e.g. .bin files or the fiber generation file with your personal paths in it).
* adding support for higher-order elements qudratic tet, hex, tri, quad, and biquadtratic quad * Fixing support for VTK_QUADRATIC_HEXAHEDRON and adding support for VTK_TRIQUADRATIC_HEXAHEDRON #114
* Simplify paths, unify fields * Fix cmm
* Update set_bc_rbnl() with svFSI bugs fixes, fix test for Robin BC. * Fix some more c++/fortran implementation differences. * Remove some debugging statements. * Update set_bc_rbnl() with svFSI bugs fixes, fix test for Robin BC. * Add Robin test * Fix typo --------- Co-authored-by: Martin R. Pfaller <[email protected]>
aabrown100-git
force-pushed
the
Holzapfel_material_model
branch
from
cd3e46f
to
8df7c46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current situation
svFSIPlus does not correctly process the Holzapfel material model for struct/ustruct. Modifications were proposed by @ktbolt in PR #131, but this was closed amid repo restructuring described here #149. Also, the original PR did not include a test case for the Holzapfel model.
Release Notes
Code of Conduct & Contributing Guidelines