Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a better error message is Int32 data is not found for GlobalNodeID. #138

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

ktbolt
Copy link
Collaborator

@ktbolt ktbolt commented Nov 10, 2023

Current situation

The solver fails if the GlobalNodeID VTK data array is not Int32 when reading a mesh.

Code of Conduct & Contributing Guidelines

@mrp089
Copy link
Member

mrp089 commented Nov 10, 2023

I still think we should enable Int64 since many Python meshing/pre-processing tools will default to that.

@mrp089 mrp089 merged commit 9afada1 into SimVascular:main Nov 10, 2023
5 checks passed
@ktbolt
Copy link
Collaborator Author

ktbolt commented Nov 10, 2023

@mrp089 I would think that preprocessing tools should conform to the format required by the application they are writing data for.

In Python if I create an array using vtk.vtkIntArray() then the data will be Int32. Int64 data has to be explicitly specified using vtk.vtkTypeInt64Array(). Maybe numpy or other libraries create Int64 arrays by default.

@ktbolt ktbolt deleted the Add-error-VTK-Int32-data-arrays_94 branch November 16, 2023 17:49
mrp089 referenced this pull request in mrp089/svFSIplus_old Nov 30, 2023
mrp089 referenced this pull request in mrp089/svFSIplus_old Nov 30, 2023
mrp089 referenced this pull request in mrp089/svFSIplus_old Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants