Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyright workflow and licensing #122

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Copyright workflow and licensing #122

merged 2 commits into from
Oct 24, 2023

Conversation

MatteoSalvador
Copy link
Collaborator

Current situation

This MR addresses #121.

Release Notes

-Add a copyright workflow that checks the license all over the Source folder at each push/pull request.
-Add license at the beginning of each .h/.cpp file.

Documentation

No need to update the documentation for this MR.

Testing

The test is basically provided by the new copyright workflow.

Code of Conduct & Contributing Guidelines

@mrp089
Copy link
Member

mrp089 commented Oct 19, 2023

Awesome, @MatteoSalvador! Does the workflow check for the license and fail if it's missing? Or automatically add the license if it's missing?

We could later move this to the .github repository so it applies to all projects in SimVascular.

@MatteoSalvador
Copy link
Collaborator Author

Thanks @mrp089! For the time being, the workflow checks for the license and fails if it's missing (or does not perfectly respect the given template). I agree with applying this workflow throughout Simvascular.

@MatteoSalvador
Copy link
Collaborator Author

@ktbolt do you have any comments on this MR? Otherwise I think it's ready to be merged!

@ktbolt
Copy link
Collaborator

ktbolt commented Oct 24, 2023

@MatteoSalvador @mrp089 There are so many other things that need to be done and we are spending time and effort on something of such little importance.

@mrp089 mrp089 merged commit eec4bd7 into SimVascular:main Oct 24, 2023
5 checks passed
@mrp089
Copy link
Member

mrp089 commented Oct 24, 2023

@ktbolt, happy to spend 5 s to click Squash and merge!

We need license headers to release svFSI+, like we have for all other solvers in SimVascular (@alisonmarsden, correct me if I'm wrong).

Great that @MatteoSalvador 1) took the initiative and added license headers, and 2) made sure all files in the future will have license headers.

@ktbolt
Copy link
Collaborator

ktbolt commented Oct 24, 2023

@mrp089 I was not referring to 1) but 2).

mrp089 referenced this pull request in mrp089/svFSIplus_old Nov 30, 2023
mrp089 referenced this pull request in mrp089/svFSIplus_old Nov 30, 2023
mrp089 referenced this pull request in mrp089/svFSIplus_old Nov 30, 2023
@MatteoSalvador MatteoSalvador deleted the copyright branch December 14, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants