feat(agent): Draft of agent group feature #6896

MKdir98 · 2024-02-23T13:06:05Z

Add divider_and_conquer strategy for use in agent members
Add AgentMember class
Add AgentGroup class
Add hire_agent and create_agent and create_task
Add test_agent_group as an integration test with VCR
Add autogpt_multi_agent.sh file to run autogpt in multi-agent mode

Background

In this PR we want to add AgentGroup feature as discussed in #6824.

The base of this PR is the AgentGroup class. This class can create a group of agents like a company. The name of this agent will be AgentMember and it will extend from Agent.

Each AgentGroup has one leader. leader is kind of AgentMember. Each AgentMember can have several AgentMember to do some task for its boss.

Main classes

AgentGroup

leader: AgentMember: This agent will be the head of this group
members: dict[str, AgentMember]: We need to have a list of all members in our tree to find an agent with the ID of that agent

AgentMember

id: str: Unique ID for each member
role: str: The role of the agent in the group
initial_prompt: str: The prompt for creating the agent
boss: Optional['AgentMember']: Boss of the agent
recruiter: Optional['AgentMember']: We can have a recruiter for agents to hire members for them
task_queue: list[Task]: A queue to store tasks for agent
members: list['AgentMember']: We need to have members to assign tasks to them
create_agent: bool: the ability to create an agent for an agent (if this was off and you need an agent, you should tell your boss)
db: AgentDB: For creating a task I need this one
group: 'AgentGroup': For run command, I need this one

Strategies

divide_and_conquer

This strategy is like one_shot strategy with some different. Every agent has a thread to check its task_queue all the time. in each iterate AgentMember loads tasks and its members and gives these values to llm_provider to get a list of commands that we want (unlike one_shot we will have a list of commands). We will have two more commands in the list of commands.

Commands

create_agent

If the create_agent property of an agent is true this agent can create a new agent for an agent.
We need these properties for this action.

prompt
role
boss_id
After this one, we will have a member for an agent with boss_id id with prompt description.

hire_agent

If the create_agent property of an agent is false and this agent wants a member, it should say to its boss or its recruiter to hire someone for it.

create_task

If they need to create a task for others, they can use this command.
task (str): The description of that task
agent_id (str): The id of the agent will be the owner of this task.
father_task_id (str): The task id that is the cause of this task.

tests

test_agent_group

This test is an integration test that will support all code that we will write. The scenario is a create best shooter game in the world. This test uses VCR for LLM responses. The VCR files have been changed (It is not the direct response of LLM). In this test we'll create an AgentGroup with the CEO as leader and the CEO will have an hr_lead as its member.

How we can run Autogpt in multi-agent mode

autogpt_multi_agent.sh

We can run Autogpt in multi-agent cli mode by this script. It is like autogpt.sh. It has just one more argument and it is member-description. The structure of member-description will be like this. --member-description "{role_name}:{description of this member}:{boolean of can create new agent or no}:{boss_index}:{recruiter_index}". It's just for starting and it will need to get better. An example of running this command and creating a new agent group can be this:

./autogpt_multi_agent.sh --member-description "tech_lead:you will be tech lead of github.com/Significant-Gravitas/AutoGPT project and 
you need to get this project better in github:False::1" --member-description "hr_lead:you will be hr of this team. you need to prepare agents for this work done.:True:0" --me
mber-description "senior_python_developer:you will be developer of this team and you will get issues to get them done:False:0"

Changes 🏗️

We didn't change something in here. We added some classes as we talked about in the Background part.

PR Quality Scorecard ✨

Have you used the PR description template? +2 pts
Is your pull request atomic, focusing on a single charge? +5 pts
Have you linked the GitHub issue(s) that this PR addresses? +5 pts
Have you documented your changes clearly and comprehensively? +5 pts
Have you changed or added a feature? -4 pts
- Have you added/updated corresponding documentation? +4 pts
- Have you added/updated corresponding integration tests? +5 pts
Have you changed the behavior of AutoGPT? -5 pts
- Have you also run agbenchmark to verify that these changes do not regress performance? +10 pts

github-actions · 2024-02-23T13:06:22Z

This PR exceeds the recommended size of 500 lines. Please make sure you are NOT addressing multiple issues with one PR.

netlify · 2024-02-23T13:07:05Z

✅ Deploy Preview for auto-gpt-docs ready!

Name	Link
🔨 Latest commit	`571985a`
🔍 Latest deploy log	https://app.netlify.com/sites/auto-gpt-docs/deploys/66251d94607b940008634ecd
😎 Deploy Preview	https://deploy-preview-6896--auto-gpt-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

MKdir98 · 2024-02-23T13:08:25Z

This PR needs to be changed. This was just for review.

ntindle · 2024-02-28T16:39:16Z

autogpts/autogpt/autogpt/agents/agent_group.py

+
+class AgentGroup:
+
+ ceo: AgentMember


Leader and member?

It's better. I'll change it

MKdir98 · 2024-03-04T08:16:05Z

I updated the pull request description. This is a just draft version and needs to be improved.

MKdir98 · 2024-03-04T08:19:24Z

One problem I have right now is that we need to have a field as sub_tasks in the AgentTask class. It will store details of sub-tasks created and the status of them. I am going to store sub-tasks in agent_task

ntindle · 2024-03-05T16:07:53Z

autogpts/autogpt/autogpt/agents/agent_member.py

+ members: list['AgentMember']
+ create_agent: bool
+ db: AgentDB
+ group: 'AgentGroup'


I'd clarify how group is conceptually different than members

I added a diagram and some description of the difference between them.

ntindle · 2024-03-09T19:21:23Z

One problem I have right now is that we need to have a field as sub_tasks in the AgentTask class. It will store details of sub-tasks created and the status of them. I am going to store sub-tasks in agent_task

Have you read the roadmap items in discussion? I think this mayyy be covered in one?

MKdir98 · 2024-03-10T04:09:35Z

One problem I have right now is that we need to have a field as sub_tasks in the AgentTask class. It will store details of sub-tasks created and the status of them. I am going to store sub-tasks in agent_task

Have you read the roadmap items in discussion? I think this mayyy be covered in one?

Could you give me the link of discussion?

ntindle · 2024-03-13T16:45:26Z

#6971

ntindle · 2024-03-14T03:11:47Z

~~Are these commands enabled? Was trying to test but can't get the llm to execute them lol~~ Commands are not being inserted into the prompt

MKdir98 · 2024-03-14T07:49:05Z

~~Are these commands enabled? Was trying to test but can't get the llm to execute them lol~~ Commands are not being inserted into the prompt

I wrote another sh file to run multi agent mode. But it's not over yet. I am working on it right now.

MKdir98 · 2024-03-14T10:25:03Z

I change the proposed action of the agent member.
I added autogpt_multi_agent.sh and a description for that in the pull request description. It's experimental. I can't get good results and commands in my tests. I will record a video if I can for my tests.

./autogpt_multi_agent.sh --member-description "tech_lead:you will be tech lead of github.com/Significant-Gravitas/AutoGPT project and 
you need to get this project better in github:False::1" --member-description "hr_lead:you will be hr of this team. you need to prepare agents for this work done.:True:0" --me
mber-description "senior_python_developer:you will be developer of this team and you will get issues to get them done:False:0"

Pwuts

Very interesting concept, and decently structured code! Check out my comments on divide_and_conquer.py, there may be something useful in there to get it to work.

Pwuts · 2024-03-15T13:14:30Z

autogpts/autogpt/autogpt/agents/agent.py

@@ -63,7 +65,7 @@ class AgentConfiguration(BaseAgentConfiguration):

 class AgentSettings(BaseAgentSettings):
 config: AgentConfiguration = Field(default_factory=AgentConfiguration)
- prompt_config: OneShotAgentPromptConfiguration = Field(
+ prompt_config: SystemConfiguration = Field(


Please specify the specific types that are valid here, not just the base class

Pwuts · 2024-03-15T13:15:01Z

autogpts/autogpt/autogpt/agents/agent.py

@@ -84,7 +86,7 @@ class Agent(
 description=__doc__,
 )

- prompt_strategy: OneShotAgentPromptStrategy
+ prompt_strategy: PromptStrategy


Same request as above

autogpts/autogpt/autogpt/agents/agent_group.py

autogpts/autogpt/autogpt/agents/prompt_strategies/divide_and_conquer.py

autogpts/autogpt/autogpt/commands/create_agent.py

autogpts/autogpt/autogpt/commands/hire_agent.py

autogpts/forge/forge/sdk/db.py

MKdir98 · 2024-03-16T21:11:11Z

If I change llm response to xml, I will get better result? (I'm getting so non-json result in my tests)
I think we have an issue for this one too.
@ntindle @Pwuts

github-actions · 2024-03-20T16:59:35Z

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

MKdir98 · 2024-04-06T08:42:50Z

For support multi-agent, you commented this Does this have to be in the Forge DB? I suggest storing this kind of state in the AgentSettings (or subclass) object, which can be serialized and stored, together with the other state of the agent. and I try to not save tasks in DB. But when I wanted to use benchmark over it, it seemed agbenchmark used uuid of that task to load it from DB. Do you have any advice for me about what should I do? @Pwuts

kcze

This is interesting and potentially worth merging!

We're working on Component-based Agents (this linked PR doesn't move code to the forge yet - it'll be done in a separate PR) which may be merged any day now. It's going to make the forge more effective and easier to build Agents. Given that, this PR will need a refactor (let me know if you need help, can be on Discord @kcze). I recommend you have a look at the Component Agents PR and linked docs.

Please use black, isort, flake8 to fix linting (docs).

kcze · 2024-04-20T13:32:20Z

autogpts/autogpt/autogpt/agents/agent_member.py

+ self.id = str(uuid.uuid4())
+ settings.agent_id = self.id


This creates two sources of truth for agent_id and so a potential for errors. If you want to have self.id better make it a @property of AgentMember. The same applies to the role (settings.ai_profile.ai_role).

kcze · 2024-04-20T13:53:58Z

autogpts/autogpt/autogpt/agents/agent_member.py

+ id: str
+ role: str
+ initial_prompt: str
+ boss: Optional["AgentMember"]
+ recruiter: Optional["AgentMember"]
+ tasks: list["AgentTask"]
+ members: list["AgentMember"]
+ create_agent: bool
+ group: "AgentGroup"


I think it may be better to move what possible to AgentMemberSettings. AgentMember may be tricky to de/serialize (circular deps in pydantic?) @Pwuts

autogpts/autogpt/autogpt/agents/agent_member.py

autogpts/autogpt/autogpt/app/main.py

autogpts/autogpt/autogpt/commands/create_task.py

autogpts/autogpt/autogpt/agents/agent_group.py

autogpts/autogpt/autogpt/agents/agent_member.py

autogpts/autogpt/autogpt/agents/prompt_strategies/divide_and_conquer.py

kcze · 2024-04-20T15:11:31Z

If I change llm response to xml, I will get better result? (I'm getting so non-json result in my tests)

This is out of scope for this PR and I doubt you will get better results at least on OpenAI which is optimized for json.

... But when I wanted to use benchmark over it, it seemed agbenchmark used uuid of that task to load it from DB. Do you have any advice for me about what should I do?

I wouldn't worry about DB for now; don't change it. Just make sure to store all data that the agent needs in AgentSettings (see #6896 (comment)).

MKdir98 · 2024-04-21T05:38:41Z

This is interesting and potentially worth merging!

We're working on Component-based Agents (this linked PR doesn't move code to the forge yet - it'll be done in a separate PR) which may be merged any day now. It's going to make the forge more effective and easier to build Agents. Given that, this PR will need a refactor (let me know if you need help, can be on Discord @kcze). I recommend you have a look at the Component Agents PR and linked docs.

Please use black, isort, flake8 to fix linting (docs).

Thank you @kcze for your great review. I'll check them as soon as I can.

MKdir98 · 2024-04-21T05:40:52Z

This is out of scope for this PR and I doubt you will get better results at least on OpenAI which is optimized for json.

Yes, you are right.

I wouldn't worry about DB for now; don't change it. Just make sure to store all data that the agent needs in AgentSettings (see #6896 (comment)).

Yeah. I found it recently. I will fix this one too for benchmark.

* Add `divider_and_conquer` strategy for using in agent members * Add `AgentMember` class * Add `AgentGroup` class * Add `hire_agent` and `create_agent` and `create_task` * Add `test_agent_group` as an intergration test with VCR * Add `AgentTaskStatus` for flow of doing tasks * Add `autogpt_multi_agent.sh` file to run autogpt in multi agent mode

Swiftyos · 2024-04-23T14:15:14Z

@CodiumAI-Agent /review

CodiumAI-Agent · 2024-04-23T14:16:53Z

PR Review

⏱️ Estimated effort to review [1-5]	4, because the PR introduces a complex new feature with multiple new classes and methods across several files. The changes involve intricate logic for agent management and task handling, which requires careful consideration to ensure correctness and maintainability.
🧪 Relevant tests	Yes
🔍 Possible issues	Possible Bug: The method `create_task` in `AgentMember` class does not handle exceptions properly. If an exception occurs, it only logs the error without any further handling, which might lead to unmanaged task states or failures in task creation without proper rollback or user notification.
🔍 Possible issues	Design Concern: The `AgentGroup` class tightly couples member management and task handling, which might make it difficult to extend or modify the behavior of agent groups without affecting task management.
🔒 Security concerns	No

Code feedback:

relevant file	autogpts/autogpt/autogpt/agents/agent_member.py
suggestion	Consider implementing exception handling in the `create_task` method to manage task state properly in case of errors. This could include rolling back changes, notifying the user, or retrying task creation. [important]
relevant line	except Exception as e:

relevant file	autogpts/autogpt/autogpt/agents/agent_group.py
suggestion	Refactor the `AgentGroup` class to separate concerns between member management and task handling. This could involve creating separate classes or methods that handle these concerns independently, improving modularity and maintainability. [important]
relevant line	class AgentGroup:

relevant file	autogpts/autogpt/autogpt/agents/agent_member.py
suggestion	Add validation for the `role`, `initial_prompt`, and `boss_id` parameters in the `create_agent_member` function to ensure they meet expected formats or conditions before processing. This can prevent issues related to invalid data being used in agent creation. [medium]
relevant line	async def create_agent_member(

relevant file	autogpts/autogpt/autogpt/agents/agent_member.py
suggestion	Optimize the `get_list_of_all_your_team_members` method by using a more efficient data structure or algorithm to handle large numbers of members, as the current recursive method could lead to performance issues with large agent trees. [medium]
relevant line	def get_list_of_all_your_team_members(self) -> list["AgentMember"]:

✨ Review tool usage guide:

Overview:
The review tool scans the PR code changes, and generates a PR review which includes several types of feedbacks, such as possible PR issues, security threats and relevant test in the PR. More feedbacks can be added by configuring the tool.

The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.

When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:

/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

With a configuration file, use the following template:

[pr_reviewer]
some_config1=...
some_config2=...

See the review usage page for a comprehensive guide on using this tool.

MKdir98 requested a review from a team as a code owner February 23, 2024 13:06

github-actions bot added the size/xl label Feb 23, 2024

ntindle reviewed Feb 28, 2024

View reviewed changes

MKdir98 force-pushed the feat/add-agent-group branch from 37ebf3a to 82f1425 Compare March 4, 2024 08:01

github-actions bot added AutoGPT Agent Forge labels Mar 4, 2024

MKdir98 force-pushed the feat/add-agent-group branch from 82f1425 to a9f2288 Compare March 4, 2024 08:23

Significant-Gravitas deleted a comment from github-actions bot Mar 4, 2024

MKdir98 force-pushed the feat/add-agent-group branch from a9f2288 to c3a9e78 Compare March 5, 2024 11:47

ntindle reviewed Mar 5, 2024

View reviewed changes

MKdir98 force-pushed the feat/add-agent-group branch from c3a9e78 to 7f2e413 Compare March 14, 2024 10:13

Pwuts requested changes Mar 15, 2024

View reviewed changes

MKdir98 force-pushed the feat/add-agent-group branch 2 times, most recently from cd78676 to c3d2edc Compare March 18, 2024 16:02

github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Mar 20, 2024

MKdir98 force-pushed the feat/add-agent-group branch from c3d2edc to 9324306 Compare April 2, 2024 03:46

github-actions bot removed the Forge label Apr 2, 2024

Significant-Gravitas deleted a comment from github-actions bot Apr 20, 2024

kcze requested changes Apr 20, 2024

View reviewed changes

MKdir98 force-pushed the feat/add-agent-group branch from 9324306 to 571985a Compare April 21, 2024 14:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(agent): Draft of agent group feature #6896

feat(agent): Draft of agent group feature #6896

MKdir98 commented Feb 23, 2024 •

edited

github-actions bot commented Feb 23, 2024

netlify bot commented Feb 23, 2024 •

edited

MKdir98 commented Feb 23, 2024

ntindle Feb 28, 2024

MKdir98 Feb 28, 2024

MKdir98 commented Mar 4, 2024

MKdir98 commented Mar 4, 2024 •

edited

ntindle Mar 5, 2024 •

edited

MKdir98 Mar 8, 2024

ntindle commented Mar 9, 2024

MKdir98 commented Mar 10, 2024 •

edited

ntindle commented Mar 13, 2024

ntindle commented Mar 14, 2024 •

edited

MKdir98 commented Mar 14, 2024

MKdir98 commented Mar 14, 2024 •

edited

Pwuts left a comment

Pwuts Mar 15, 2024

Pwuts Mar 15, 2024

MKdir98 commented Mar 16, 2024 •

edited

github-actions bot commented Mar 20, 2024

MKdir98 commented Apr 6, 2024

kcze left a comment

kcze Apr 20, 2024

kcze Apr 20, 2024

kcze commented Apr 20, 2024

MKdir98 commented Apr 21, 2024

MKdir98 commented Apr 21, 2024

Swiftyos commented Apr 23, 2024

CodiumAI-Agent commented Apr 23, 2024

feat(agent): Draft of agent group feature #6896

Are you sure you want to change the base?

feat(agent): Draft of agent group feature #6896

Conversation

MKdir98 commented Feb 23, 2024 • edited

Background

Main classes

AgentGroup

AgentMember

Strategies

divide_and_conquer

Commands

create_agent

hire_agent

create_task

tests

test_agent_group

How we can run Autogpt in multi-agent mode

autogpt_multi_agent.sh

Changes 🏗️

PR Quality Scorecard ✨

github-actions bot commented Feb 23, 2024

netlify bot commented Feb 23, 2024 • edited

✅ Deploy Preview for auto-gpt-docs ready!

MKdir98 commented Feb 23, 2024

ntindle Feb 28, 2024

Choose a reason for hiding this comment

MKdir98 Feb 28, 2024

Choose a reason for hiding this comment

MKdir98 commented Mar 4, 2024

MKdir98 commented Mar 4, 2024 • edited

ntindle Mar 5, 2024 • edited

Choose a reason for hiding this comment

MKdir98 Mar 8, 2024

Choose a reason for hiding this comment

ntindle commented Mar 9, 2024

MKdir98 commented Mar 10, 2024 • edited

ntindle commented Mar 13, 2024

ntindle commented Mar 14, 2024 • edited

MKdir98 commented Mar 14, 2024

MKdir98 commented Mar 14, 2024 • edited

Pwuts left a comment

Choose a reason for hiding this comment

Pwuts Mar 15, 2024

Choose a reason for hiding this comment

Pwuts Mar 15, 2024

Choose a reason for hiding this comment

MKdir98 commented Mar 16, 2024 • edited

github-actions bot commented Mar 20, 2024

MKdir98 commented Apr 6, 2024

kcze left a comment

Choose a reason for hiding this comment

kcze Apr 20, 2024

Choose a reason for hiding this comment

kcze Apr 20, 2024

Choose a reason for hiding this comment

kcze commented Apr 20, 2024

MKdir98 commented Apr 21, 2024

MKdir98 commented Apr 21, 2024

Swiftyos commented Apr 23, 2024

CodiumAI-Agent commented Apr 23, 2024

PR Review

MKdir98 commented Feb 23, 2024 •

edited

netlify bot commented Feb 23, 2024 •

edited

MKdir98 commented Mar 4, 2024 •

edited

ntindle Mar 5, 2024 •

edited

MKdir98 commented Mar 10, 2024 •

edited

ntindle commented Mar 14, 2024 •

edited

MKdir98 commented Mar 14, 2024 •

edited

MKdir98 commented Mar 16, 2024 •

edited