[WIP]Feature, configurable network port #6678
Conversation
✅ Deploy Preview for auto-gpt-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lukolszewski
changed the title
| try: | ||
| pids = subprocess.check_output(["lsof", "-t", "-i", ":8000"]).split() | ||
| pids = subprocess.check_output(["lsof", "-t", "-i", ":"+str(agent_port)]).split() |
There was a problem hiding this comment.
| pids = subprocess.check_output(["lsof", "-t", "-i", ":"+str(agent_port)]).split() | |
| pids = subprocess.check_output(["lsof", "-t", "-i", f":{agent_port}"]).split() |
| @@ -314,7 +317,7 @@ def stop(): | |||
| click.echo("No process is running on port 8000") | |||
There was a problem hiding this comment.
| click.echo("No process is running on port 8000") | |
| click.echo(f"No process is running on port {agent_port}") |
| agent_port: int = UserConfigurable( | ||
| default=8000, | ||
| from_env=lambda: int(v) if (v := os.getenv("AGENT_PORT")) else None, | ||
| ) |
There was a problem hiding this comment.
This should be in the "Application Settings" section, e.g. on line 55. Also, can you rename agent_port to serve_port or agent_serve_port?
| kill $(lsof -t -i :8000) | ||
| kill $(lsof -t -i :${AGENT_PORT:-8080}) |
There was a problem hiding this comment.
- This should default to 8000 like it does now
- This will break the benchmark when
AGENT_PORTis not set to its default, because AGBenchmark uses thehostproperty (including port) fromagbenchmark_config/config.jsonto connect to the subject agent's API.
| set -a | ||
| source .env | ||
| set +a | ||
| python3 cli.py "$@" |
|
|
||
| python3 cli.py "$@" | ||
| set -a | ||
| source .env |
There was a problem hiding this comment.
For most users, .env does not exist and this shows a warning.
There was a problem hiding this comment.
AGBenchmark reads PORT, not BENCHMARK_PORT:
AutoGPT/benchmark/agbenchmark/__main__.py
Lines 191 to 193 in 25cc6ad
| @@ -368,7 +368,7 @@ async def run_auto_gpt_server( | |||
| server = AgentProtocolServer( | |||
| app_config=config, database=database, llm_provider=llm_provider | |||
| ) | |||
| await server.start() | |||
| await server.start(port=config.serving_port) | |||
There was a problem hiding this comment.
does not match the config attribute created in config.py
|
Just merged #6569 which makes the port configurable but doesn't touch the |
|
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
github-actions
bot
added
the
conflicts
Background
This implements a configurable network port. I often have other stuff running locally on port 8000 and I wanted to be able to change this default.
Changes 🏗️
This only adds a config option named serving_port which reads the environment variable PORT, if this is not present it defaults to 8000.
PR Quality Scorecard ✨
+2 pts+5 pts+5 pts+5 pts-4 pts+4 pts+5 pts-5 ptsagbenchmarkto verify that these changes do not regress performance?+10 pts