-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Needed for Discord bot] Segment Interview and Spec Generation #62
Merged
ntindle
merged 25 commits into
main
from
ntindle/agpt-400-update-post-spec-to-schedule-a-background-task-for
Mar 1, 2024
Merged
[Needed for Discord bot] Segment Interview and Spec Generation #62
ntindle
merged 25 commits into
main
from
ntindle/agpt-400-update-post-spec-to-schedule-a-background-task-for
Mar 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-a-background-task-for
Todo:
|
ntindle
changed the title
Update to interview and backgorund schedule specs
Segment Interview and Spec Generation
Feb 29, 2024
ntindle
commented
Feb 29, 2024
ntindle
commented
Feb 29, 2024
ntindle
commented
Feb 29, 2024
ntindle
changed the title
Segment Interview and Spec Generation
[Needed for Discord bot] Segment Interview and Spec Generation
Mar 1, 2024
majdyz
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I hope we can follow-up on adding one test on test_api.py
to prevent from us breaking this code :)
ntindle
deleted the
ntindle/agpt-400-update-post-spec-to-schedule-a-background-task-for
branch
March 1, 2024 05:14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turns the Spec generation into the same style as the other blocks and extracts the interview stage and modifies it a bit to support a bit more of a rest style api. The codex client is now responsible for stepping through the interview phases and answering questions that come with each phase before ultimately calling generate spec
Also requires a cloud service id and interview id for Identifiers now
may want to consider seeding our users into CODEX and Cloud Services with compatible Ids and correct discords and such for core devs of the services