Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DB Schema updates #30

Merged
merged 23 commits into from
Feb 21, 2024
Merged

DB Schema updates #30

merged 23 commits into from
Feb 21, 2024

Conversation

ntindle
Copy link
Member

@ntindle ntindle commented Feb 15, 2024

Discussions in comments

@linear Linear
Copy link

linear bot commented Feb 15, 2024

AGPT-288 Review DB Design

ntindle
ntindle commented Feb 15, 2024
View reviewed changes
schema.prisma Show resolved Hide resolved
schema.prisma Show resolved Hide resolved
schema.prisma Show resolved Hide resolved
schema.prisma Show resolved Hide resolved
schema.prisma Show resolved Hide resolved
schema.prisma Show resolved Hide resolved
schema.prisma Show resolved Hide resolved
schema.prisma Outdated Show resolved Hide resolved
schema.prisma Outdated Show resolved Hide resolved
schema.prisma Show resolved Hide resolved
@ntindle ntindle requested a review from Swiftyos February 15, 2024 01:15
Swiftyos
Swiftyos reviewed Feb 15, 2024
View reviewed changes
Copy link
Contributor

@Swiftyos Swiftyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why I didn't add all those comments as a review..

Torantulino
Torantulino reviewed Feb 15, 2024
View reviewed changes
Copy link
Member

@Torantulino Torantulino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just leaving a note to say I've read the on-going discussions - I appreciate all the pragmatic thinking. I don't see much for me to clarify in terms of direction other than I agree that we'll likely want to build a non-discord GUI for Codex (and/or AutoGPT) in the future.

ntindle
ntindle commented Feb 16, 2024
View reviewed changes
schema.prisma Show resolved Hide resolved
@ntindle ntindle requested a review from Swiftyos February 16, 2024 04:08
majdyz
majdyz reviewed Feb 19, 2024
View reviewed changes
schema.prisma Show resolved Hide resolved
majdyz
majdyz reviewed Feb 19, 2024
View reviewed changes
schema.prisma Show resolved Hide resolved
majdyz
majdyz reviewed Feb 19, 2024
View reviewed changes
schema.prisma Outdated Show resolved Hide resolved
majdyz
majdyz reviewed Feb 19, 2024
View reviewed changes
schema.prisma Outdated Show resolved Hide resolved
majdyz
majdyz reviewed Feb 19, 2024
View reviewed changes
schema.prisma Outdated Show resolved Hide resolved
majdyz
majdyz reviewed Feb 19, 2024
View reviewed changes
schema.prisma Outdated Show resolved Hide resolved
majdyz
majdyz reviewed Feb 19, 2024
View reviewed changes
schema.prisma
password String?
deleted Boolean @default(false)
apps Application[]
spes Specification[]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be Apps and Specs then?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really follow, but happy with whatever you would like to do

majdyz
majdyz reviewed Feb 19, 2024
View reviewed changes
schema.prisma Outdated Show resolved Hide resolved
@Swiftyos
Copy link
Contributor

The idea of this PR is to ensure we are following best practices and being consistent.
@ntindle has views on this and will advice.

We also identified 3 additional tasks we will need to look into, which are out of scope for this task:

  1. Move user management out to cloud services (AGPT-389)
  2. Update how we want to handle passing database schemas (AGPT-388)
  3. Update how we want to handle passing parameters (AGPT-387)

Swiftyos
Swiftyos approved these changes Feb 19, 2024
View reviewed changes
schema.prisma Show resolved Hide resolved
schema.prisma Outdated Show resolved Hide resolved
schema.prisma Outdated Show resolved Hide resolved
schema.prisma Show resolved Hide resolved
schema.prisma Outdated Show resolved Hide resolved
schema.prisma Show resolved Hide resolved
schema.prisma Show resolved Hide resolved
schema.prisma Show resolved Hide resolved
schema.prisma Show resolved Hide resolved
schema.prisma Show resolved Hide resolved
@Swiftyos
Copy link
Contributor

FYI we are holding on merging this until AGPT-288 us completed

@Swiftyos Swiftyos merged commit b0d9b0c into main Feb 21, 2024
1 check passed
@Swiftyos Swiftyos deleted the ntindle/agpt-288 branch February 21, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majdyz majdyz majdyz left review comments

@Torantulino Torantulino Torantulino left review comments

@Swiftyos Swiftyos Swiftyos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ntindle @Swiftyos @Torantulino @majdyz