Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple prompt changes to help interview #276

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

Bentlybro
Copy link
Member

@Bentlybro Bentlybro commented Jun 3, 2024

User description

These prompt changes seem to help it properly understand when the user is happy and wants to continue

image
image


PR Type

enhancement


Description

  • Enhanced the detection of user satisfaction to determine phase completion.
  • Clarified the conditions for setting phase_completed to true across multiple prompt files.
  • Updated instructions to exclude modules or features list when phase_completed is true.

Changes walkthrough 📝

Relevant files
Enhancement
system.j2
Improve phase completion detection and response clarity   

codex/prompts/gpt-4o/interview/module/system.j2

  • Updated instructions to detect user satisfaction for phase completion.
  • Clarified conditions for setting phase_completed to true.
  • Specified not to include modules list if phase_completed is true.
  • +3/-2     
    system.j2
    Improve phase completion detection and response clarity   

    codex/prompts/gpt-4o/interview/understand/system.j2

  • Updated instructions to detect user satisfaction for phase completion.
  • Clarified conditions for setting phase_completed to true.
  • Specified not to include modules list if phase_completed is true.
  • +3/-3     
    system.j2
    Improve phase completion detection and response clarity   

    codex/prompts/gpt-4o/interview/update/system.j2

  • Updated instructions to detect user satisfaction for phase completion.
  • Clarified conditions for setting phase_completed to true.
  • Specified not to include features list if phase_completed is true.
  • +3/-2     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Copy link

    linear bot commented Jun 3, 2024

    AGPT-746

    @qodo-merge-pro qodo-merge-pro bot added the enhancement New feature or request label Jun 3, 2024
    Copy link

    qodo-merge-pro bot commented Jun 3, 2024

    PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

    PR Description updated to latest commit (7d7758d)

    Copy link

    qodo-merge-pro bot commented Jun 3, 2024

    PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

    PR Review 🔍

    ⏱️ Estimated effort to review [1-5]

    2, because the changes are straightforward and localized to specific conditions in the prompt handling logic. The modifications are consistent across multiple files, which simplifies the review process.

    🧪 Relevant tests

    No

    ⚡ Possible issues

    Ambiguity in Detection Logic: The new condition "Detect if the user is happy and wants to move on to the next phase" might be too vague and could lead to inconsistent behavior depending on the implementation of the detection logic. It would be beneficial to specify what constitutes happiness or satisfaction in this context.

    🔒 Security concerns

    No

    Copy link

    qodo-merge-pro bot commented Jun 3, 2024

    PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

    PR Code Suggestions ✨

    No code suggestions found for PR.

    @Bentlybro Bentlybro merged commit d93565d into main Jun 3, 2024
    3 checks passed
    @Bentlybro Bentlybro deleted the bently/agpt-746-improve-the-codex-interview-prompt branch June 3, 2024 12:53
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants