Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Keywords to Different Senses #1276

Merged
merged 20 commits into from
Jul 27, 2024
Merged

Move Keywords to Different Senses #1276

merged 20 commits into from
Jul 27, 2024

Conversation

susanodd
Copy link
Collaborator

@susanodd susanodd commented Jun 27, 2024

This is live on signbank-susan

Part 1. Matrix modal converted to panel.
Part 2. Language modals converted to panels.

  • Removed modals. Removed "keywords" column that was on the old page. Put placeholders that show the language name in empty fields. (The original version is visible on signbank.)

  • One thing I am not able to do is due to the design of the signbank Language model. The languages need to be consistently sorted by ID in order to maintain the same sorting order. They cannot be sorted by name here because that depends on the interface language.

What is a good title for this page?
I like any:

  • Move Keywords to Different Senses
  • Split Up Keywords into Different Senses
  • Batch Edit Senses

This is intended so users do not need to do "cut and paste" and don't need to retype keywords in a different sense.
This helps the kind of RSI due to typing text.

Part 1. Matrix modal converted to panel.
@susanodd susanodd changed the title Batch Edit Senses (vision of toggle keywords) Batch Edit Senses (revision of toggle keywords) Jun 27, 2024
@susanodd
Copy link
Collaborator Author

susanodd commented Jun 27, 2024

This is live on signbank-susan

You need to do a query on one dataset, then go to Analysis -> Batch Edit Senses
or Analyse -> Batchbewerking betekenissen

I cannot figure out how to get "all the languages next to each other" in the area showing the Sense # and allowing to change the sense number and move the keywords.

All the things you can see and change dynamically update all the other things you can see.

@susanodd susanodd changed the title Batch Edit Senses (revision of toggle keywords) Move Keywords to Different Senses Jun 29, 2024
@susanodd
Copy link
Collaborator Author

susanodd commented Jun 29, 2024

Most recent look:

split-senses-afhankelijk-A

Revised layout some.

Reverted to sort languages by ID again. It does not work to sort by reverse of ID. English remains the first language because it has id 1.
@susanodd
Copy link
Collaborator Author

susanodd commented Jul 1, 2024

If the languages are sorted by name, then this depends on the interface language.

@susanodd
Copy link
Collaborator Author

susanodd commented Jul 1, 2024

Here's the other panel,

split-senses-duivel

@Woseseltops
Copy link
Collaborator

You've got my approval code wise, but before we put this live I'd like to know how Ulrika (as user representative) feels about the functionality. Okay with you @susanodd ?

@Woseseltops Woseseltops requested a review from uklomp July 5, 2024 12:26
@susanodd
Copy link
Collaborator Author

susanodd commented Jul 5, 2024

You've got my approval code wise, but before we put this live I'd like to know how Ulrika (as user representative) feels about the functionality. Okay with you @susanodd ?

Yes, I agree.
(It's basically the same code functionality as before, just different layout.)

@uklomp
Copy link
Collaborator

uklomp commented Jul 19, 2024

I commented on the issue.

susanodd added 2 commits July 22, 2024 14:52
regrouped in regroup area to proper location in matrix when more than one is regrouped at the same time.
@susanodd
Copy link
Collaborator Author

I'm going to merge this with master on Monday.

@susanodd susanodd merged commit 072ae98 into master Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants