Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for editing annotated sentences issue #1234 #1255

Merged
merged 5 commits into from
Jun 5, 2024

Conversation

Jetske
Copy link
Collaborator

@Jetske Jetske commented Jun 4, 2024

No description provided.

@Jetske Jetske linked an issue Jun 4, 2024 that may be closed by this pull request
@Jetske Jetske requested a review from susanodd June 4, 2024 11:13
@susanodd
Copy link
Collaborator

susanodd commented Jun 5, 2024

@Jetske I put this branch on signbank-dev to make sure the migration works okay.

I'm not able to test this myself because of the eaf files.

Can you check whether it works as expected?
Then I'll merge it with master and then merge it into the api_interface branch so all the branches are using the migration.

@Jetske
Copy link
Collaborator Author

Jetske commented Jun 5, 2024

@susanodd this should be ready to merge, can you do that and deploy? It has one migration.

@susanodd
Copy link
Collaborator

susanodd commented Jun 5, 2024

@susanodd this should be ready to merge, can you do that and deploy? It has one migration.

Okay!

@susanodd susanodd merged commit ab2ec7b into master Jun 5, 2024
@Jetske
Copy link
Collaborator Author

Jetske commented Jun 5, 2024

Oh at the same time! I will check quickly on dev and let you know if it's okay!

@Jetske
Copy link
Collaborator Author

Jetske commented Jun 5, 2024

Sorry, I notice that I need to change something still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Annotated sentences improvements
2 participants