Skip to content

Commit

Permalink
fix: Fix #1275 Add owner to selected Dataset instead of default
Browse files Browse the repository at this point in the history
  • Loading branch information
vanlummelhuizen committed Jun 27, 2024
1 parent 18aa32c commit fb97037
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 18 deletions.
16 changes: 1 addition & 15 deletions signbank/dictionary/adminviews.py
Original file line number Diff line number Diff line change
Expand Up @@ -4249,21 +4249,7 @@ def render_to_add_owner_response(self, context):
messages.add_message(self.request, messages.ERROR, _('You must be in group Dataset Manager to modify dataset permissions.'))
return HttpResponseRedirect(settings.PREFIX_URL + '/datasets/available')

# if the dataset is specified in the url parameters, set the dataset_acronym variable
get = self.request.GET
if 'dataset_acronym' in get:
self.dataset_acronym = get['dataset_acronym']
if self.dataset_acronym == '':
messages.add_message(self.request, messages.ERROR, _('Dataset name must be non-empty.'))
return HttpResponseRedirect(settings.PREFIX_URL + '/datasets/available')

try:
dataset_object = Dataset.objects.get(acronym=self.dataset_acronym)
except ObjectDoesNotExist:
translated_message = _('No dataset with that name found.')
messages.add_message(self.request, messages.ERROR, translated_message)
return HttpResponseRedirect(settings.PREFIX_URL + '/datasets/available')

username = ''
if 'username' in get:
username = get['username']
Expand All @@ -4279,7 +4265,7 @@ def render_to_add_owner_response(self, context):
return HttpResponseRedirect(settings.PREFIX_URL + '/datasets/available')

# if we get to here, we have a dataset object and a user object to add as an owner of the dataset

dataset_object = self.object
dataset_object.owners.add(user_object)
dataset_object.save()

Expand Down
3 changes: 0 additions & 3 deletions signbank/dictionary/templates/dictionary/dataset_detail.html
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,6 @@ <h3>{% trans "Dataset Details" %}</h3>
{% if "change_dataset" in dataset_perms %}
{% if request.user|has_group:"Dataset_Manager" %}
<form name='add_owner_form' id='add_owner_form' method='get'>
<div class="hidden">
<input name='dataset_name' id='dataset_name' class='form-control' value='{{dataset.name}}' >
</div>
<table class='table table-condensed'>
<tr>
<td>
Expand Down

0 comments on commit fb97037

Please sign in to comment.