fix(portal): use window.location.origin instead of the window.location.href #6770
Conversation
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 17dce3f in 9 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. frontend/src/container/AppLayout/index.tsx:275
- Draft comment:
Ensure thatwindow.location.originis the intended behavior forsuccessURL. This change will redirect to the base URL instead of the full path, which is often desired for success redirects. - Reason this comment was not posted:
Confidence changes required:50%
The change fromwindow.location.hreftowindow.location.originis appropriate for thesuccessURLas it should redirect to the base URL, not the full path.
Workflow ID: wflow_di0P8LHL2DJLY9SJ
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on da9bb01 in 12 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. frontend/src/container/AppLayout/index.tsx:276
- Draft comment:
The change fromwindow.location.hreftowindow.location.originis appropriate here to prevent issues with large URLs. Ensure that thesuccessURLandcancelURLare correctly handled by the backend to avoid any unexpected behavior. - Reason this comment was not posted:
Confidence changes required:20%
The change fromwindow.location.hreftowindow.location.originis consistent with the PR description and intent to avoid largereturn_url.
Workflow ID: wflow_tBrVCORWx3paEebd
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Summary
return_urlis too large, instead use the origin onlyRelated Issues / PR's
contributes to - https://github.com/SigNoz/engineering-pod/issues/2129