Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle-large-traces #4903

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

fix: handle-large-traces #4903

wants to merge 2 commits into from

Conversation

makeavish
Copy link
Member

@makeavish makeavish commented Apr 23, 2024 •
edited

Summary

  1. Fix span not found error when opening large traces from Traces tab
  2. Fix query service crashing with OOM errors due to loading huge traces in memory by introducing max span in trace limit with variable: MAX_SPANS_IN_TRACE, set to 50000 by default
  3. Allow changing SPAN_RENDER_LIMIT with spanRenderLimit param in trace detail URL - Will need frontend change, should not be required for now as SPAN_RENDER_LIMIT is just an env variable. Will update it later

@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the bug Something isn't working label Apr 23, 2024
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

3 similar comments
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikanthccv srikanthccv Awaiting requested review from srikanthccv

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@makeavish @srikanthccv