feat: allow using the consistent naming with the signoz collector #4865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-hulk
force-pushed
the
add-cluster-name-flag
branch
from
5c124eb
to
4cf9d7b
Compare
git-hulk
changed the title
git-hulk
force-pushed
the
add-cluster-name-flag
branch
2 times, most recently
from
7f95aab
to
2d6bd8a
Compare
|
@srikanthccv I didn't remove the old flag |
srikanthccv
reviewed
Apr 27, 2024
...ardingContainer/Modules/AwsMonitoring/ECSExternal/md-docs/ecsExternal-createDaemonService.md
Outdated
Show resolved
Hide resolved
| @@ -52,6 +52,8 @@ func main() { | |||
| flag.StringVar(&cacheConfigPath, "experimental.cache-config", "", "(cache config to use)") | |||
| flag.StringVar(&fluxInterval, "flux-interval", "5m", "(cache config to use)") | |||
| flag.StringVar(&cluster, "cluster", "cluster", "(cluster name - defaults to 'cluster')") | |||
| // Allow using the consistent naming with the signoz collector | |||
| flag.StringVar(&cluster, "cluster-name", "cluster", "(cluster name - defaults to 'cluster')") | |||
There was a problem hiding this comment.
Wouldn't this override the --cluster always i.e even if someone provided --cluster=my-cluster the value would be default cluster from --cluster-name arg?
There was a problem hiding this comment.
@srikanthccv No, it won't be overridden unless the --cluster-name is provided since the flag parse was only invoked while the flag name was passed. That said, if users specify:
--cluster ABC, then the cluster will be ABC--cluster-name DEF, then the cluster will be DEF--cluster ABC --cluster-name DEF, then the cluster will be DEF--cluster-name DEF --cluster ABC, then the cluster will be ABC
git-hulk
force-pushed
the
add-cluster-name-flag
branch
from
8849c42
to
7cb64b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow using the consistent ClickHouse cluster name in the collector and query service.
Related Issues / PR's
This resolves SigNoz/signoz-otel-collector#308