Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use --cluster instead of --cluster-name in migrator command flag #308

Open
git-hulk opened this issue Mar 29, 2024 · 2 comments · May be fixed by SigNoz/signoz#4865
Open

Use --cluster instead of --cluster-name in migrator command flag #308

git-hulk opened this issue Mar 29, 2024 · 2 comments · May be fixed by SigNoz/signoz#4865

Comments

@git-hulk
Copy link
Contributor

Currently, the otel collector is using the --cluster-name to pass the ClickHouse name, but the signoz query component is using --cluster. See:

[1] https://github.com/SigNoz/signoz-otel-collector/blob/main/cmd/signozschemamigrator/migrate.go#L41
[2] https://github.com/SigNoz/signoz/blob/develop/pkg/query-service/main.go#L54

Not sure if it sounds good to add an extra --cluster to keep consistent with the query component, or add an extra option --cluster-name in the query component?

I will be happy to submit a PR to resolve this if it sounds good.
@srikanthccv
Copy link
Member

Let's change the query service arg to --cluster-name.

@git-hulk
Copy link
Contributor Author

@srikanthccv Thank you! Will do it soon.

@git-hulk git-hulk linked a pull request Apr 15, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: allow using the consistent naming with the signoz collector git-hulk/signoz
2 participants
@git-hulk @srikanthccv