Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Monitoring Azure Blob Store #1692

Merged
merged 15 commits into from
May 23, 2024
Merged

Conversation

jaikanthjay46
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Apr 27, 2024

Deploy Preview for frosty-austin-928e43 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 31a0e39
🔍 Latest deploy log https://app.netlify.com/sites/frosty-austin-928e43/deploys/664cc59cfd053c000823d428
😎 Deploy Preview https://deploy-preview-1692--frosty-austin-928e43.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shivanshuraj1333
Copy link
Member

shivanshuraj1333 commented Apr 29, 2024

Hey @jaikanthjay46 is this duplicate of #1691 and #1689?

@shivanshuraj1333
Copy link
Member

Can you combine all the PRs?
#1692
#1691
#1689
#1688
Most of the content is same in all of them, let's keep this one and add everything here.
Thanks!

Copy link

github-actions bot commented Apr 30, 2024

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 25
🟠 Accessibility 89
🟢 Best practices 92
🟠 SEO 82
🟢 PWA 100

Lighthouse ran on https://deploy-preview-1692--frosty-austin-928e43.netlify.app/

@jaikanthjay46
Copy link
Contributor Author

@shiva1333 -- It was supposed to be reviewed in order 1657, then 1688, etc but the PR got ahead of the reviews. I have closed all the others, you can review the whole thing here.

@shivanshuraj1333
Copy link
Member

@jaikanthjay46 can you update the PR description with

  1. What all components inside Azure are covered?
  2. Have you done the testing following the docs?
  3. Wheather you are collecting applications as well as infra metrics.

@shivanshuraj1333
Copy link
Member

shivanshuraj1333 commented May 1, 2024

@Calm-Rock can you start the testing? With a ready environment, we can see if there's any missing information.

@Calm-Rock Calm-Rock self-requested a review May 13, 2024 09:17
@jaikanthjay46 jaikanthjay46 marked this pull request as ready for review May 21, 2024 16:03
@Calm-Rock Calm-Rock merged commit d5f6548 into SigNoz:main May 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants