Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: 🔧 disable internal metrics collection of OtelCollectors and Clickhouse #328

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: 🔧 disable internal metrics collection of OtelCollectors and Clickhouse #328

wants to merge 1 commit into from

Conversation

prashant-shahi
Copy link
Member

Disabling the default behaviour of internal metrics collection. And let the users enable it on their own if they want to.

Signed-off-by: Prashant Shahi [email protected]

@prashant-shahi
Copy link
Member Author

TODO: Create docs for enabling internal metrics collection for ClickHouse and OtelCollectors.

/cc @ankit01-oss

srikanthccv
srikanthccv approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would .../scrape: false do the same thing?

@prashant-shahi
Copy link
Member Author

@srikanthccv yes, it would. The pod annotation signoz.io/scrape is needed to be true for enabling metrics scraping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikanthccv srikanthccv srikanthccv approved these changes

@nityanandagohain nityanandagohain nityanandagohain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prashant-shahi @srikanthccv @nityanandagohain