Prometheus encoding #1525
Prometheus encoding #1525
Conversation
There was a problem hiding this comment.
Some of this might already be broken due to the API refactor going on in the api-breakers branch.
I'd rebase this PR on that branch to make sure it's using the latest return types and endpoints.
alerts/prometheus.go
Outdated
There was a problem hiding this comment.
we should add an integration test to /internal/test/e2e/prometheus.go which fetches all those metrics and makes sure they are sane. Which just means fetching all the metrics from various endpoints, checking that the name matches our expectations, the labels exist, the value is set to a value that's not 0 and the timestamp is set to something.
There was a problem hiding this comment.
How do you want to handle client end of these requests for the test? Should I just do it in ad hoc way and make an HTTP request helper or should there be a Jape client for the Prometheus endpoints?
Continuation of #1068
Addressed some of the concerns in the reviews:
PrometheusMetricmethod to original type where possiblewriteResponselogic to api packagejape