Merge pull request #23 from SiaFoundation/dont-check-write

Don't check that GET response is written if type checking is disabled
SiaFoundation · Sep 12, 2024 · 9cb99e8 · 9cb99e8
2 parents 8982ce1 + 158ef42
commit 9cb99e8
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/analyzer.go b/analyzer.go
@@ -197,7 +197,7 @@ func parseServerRoute(kv *ast.KeyValueExpr, pass *analysis.Pass) (*serverRoute,
 						})
 						return false
 					}
-					if r.response == types.Typ[types.UntypedNil] {
+					if checkTypes && r.response == types.Typ[types.UntypedNil] {
 						pass.Report(analysis.Diagnostic{
 							Pos:     call.Args[0].Pos(),
 							Message: fmt.Sprintf("%v routes should write a response object", r.method),
@@ -356,7 +356,7 @@ func parseServerRoute(kv *ast.KeyValueExpr, pass *analysis.Pass) (*serverRoute,
 		r.response = types.Typ[types.UntypedNil]
 	}
 
-	if r.method == "GET" && r.response == types.Typ[types.UntypedNil] {
+	if checkTypes && r.method == "GET" && r.response == types.Typ[types.UntypedNil] {
 		pass.Report(analysis.Diagnostic{
 			Pos:     funcBody.Pos(),
 			Message: fmt.Sprintf("%v routes should write a response object", r.method),