Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V19.0.5 shopify 1 #179

Merged
merged 6 commits into from
Jul 29, 2024
Merged

V19.0.5 shopify 1 #179

merged 6 commits into from
Jul 29, 2024

Conversation

shanth96
Copy link

Ran the following command:

ruby version_builder_v2.rb --version=19.0.5 --previous_release=v19.0.4-shopify-2 
Ignoring eventmachine-1.2.7 because its extensions are not built. Try: gem pristine eventmachine --version 1.2.7
The following commits are necessary for target version 19.0.5:
a9b168b4cf8eb6b18f668d76cf37360d8ad084cc, PR: 146
448060c4a65618f2238d63c694c35534869bf070, PR: 102
a7ad1c7204de4479ab778602f303b420dd217722, PR: 148
a313528e81db6e3cbd938036edc11b1cd23b7ecb, PR: 161
bc37e52f38568ab199a26890ba034ebdbec7b7a7, PR: 164
4b24c58989675babc2056fe68c8f9f08b48d0a7d, PR: 175

git cherry-pick -x a9b168b4cf8eb6b18f668d76cf37360d8ad084cc
git cherry-pick -x -m 1 448060c4a65618f2238d63c694c35534869bf070
git cherry-pick -x -m 1 a7ad1c7204de4479ab778602f303b420dd217722
git cherry-pick -x -m 1 a313528e81db6e3cbd938036edc11b1cd23b7ecb
git cherry-pick -x -m 1 bc37e52f38568ab199a26890ba034ebdbec7b7a7
git cherry-pick -x -m 1 4b24c58989675babc2056fe68c8f9f08b48d0a7d

jeremycole and others added 6 commits July 26, 2024 17:49
@jeremycole @shanth96
Add new placement Vindex strategy
2b4f950 
Signed-off-by: Jeremy Cole <[email protected]>

Sprinkle addPadding everywhere when comparing KeyRange Start/End values

Implement support for PartialVindex usage

Signed-off-by: Jeremy Cole <[email protected]>
(cherry picked from commit 7424fff)
(cherry picked from commit 69e6248)
(cherry picked from commit 8390560)
(cherry picked from commit b0cad30)
(cherry picked from commit a9b168b)
@brendar @shanth96
Merge pull request #102 from Shopify/generate-cachedsize-for-placemen…
c0eeea8 
…t-vindex

Generate CachedSize function for Placement vindex

(cherry picked from commit 986ffc6)
(cherry picked from commit 1fe7126)
(cherry picked from commit 62a60b2)
(cherry picked from commit f258063)
(cherry picked from commit 448060c)
@shanth96
Merge pull request #148 from Shopify/fix-tests
1435f6f 
Run all relevant tests on all PRs

(cherry picked from commit b55dd26)
(cherry picked from commit 8feee14)
(cherry picked from commit 6bc3c08)
(cherry picked from commit 33b5962)
(cherry picked from commit a7ad1c7)
@shivnagarajan @shanth96
Merge pull request #161 from Shopify/fix_e2e_test_v17
bb561e3 
fix for e2e test issue on v17

(cherry picked from commit 6a86fc9)
(cherry picked from commit a4df282)
(cherry picked from commit a313528)
@shivnagarajan @shanth96
Merge pull request #164 from Shopify/fix_tests_for_v18
437b986 
fix tests for CI

(cherry picked from commit aa73e7f)
(cherry picked from commit bc37e52)
@brendar @shanth96
Merge pull request #175 from Shopify/v19.0.4-shopify-2-candidate-back…
1b71895 
…port-vtcombo-vschema

Backport: VTCombo: Ensure VSchema exists when creating keyspace (vitessio#16094)
(cherry picked from commit 4b24c58)
@shanth96 shanth96 requested a review from brendar July 26, 2024 21:52
brendar
brendar approved these changes Jul 29, 2024
View reviewed changes
Copy link

@brendar brendar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we'll need to follow up with a PR to fix the runs-on for two new workflows trying to use gh-hosted-runners-4cores-1:

@shanth96 shanth96 merged commit 7461f20 into v19.0.5-shopify-1 Jul 29, 2024
203 of 206 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendar brendar brendar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shanth96 @brendar @jeremycole @shivnagarajan