Skip to content

Commit

Permalink
Updated go version to fix 3 CVEs (#559)
Browse files Browse the repository at this point in the history
* Updated go version to fix  3 CVEs

* Verifying updating the golangci version fixes the issue of not being able to load rules.

* Disabling depguard as the newer version of depguard included in golangci-lint requires list of acceptable packages.

* Fixed the random generator lint on test

* Adding the comment to ignore like in tests as its started to scan these errors

* Removed redundant string to fix yaml linter

* Updating the version of go in golangci.yml, fixing the linters and added unreleased changelog

* Added pr number and author to changelog
  • Loading branch information
dianadevasia authored Mar 12, 2024
1 parent ebf6568 commit c2fedde
Show file tree
Hide file tree
Showing 17 changed files with 180 additions and 153 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
- name: golangci-lint
uses: golangci/golangci-lint-action@3a919529898de77ec3da873e3063ca4b10e7f5cc
with:
version: v1.52.2
version: v1.56.2

- name: shellcheck
uses: azohra/shell-linter@6bbeaa868df09c34ddc008e6030cfe89c03394a1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ jobs:
name: Set up Go
uses: actions/setup-go@v4
with:
go-version: 1.19
go-version: 1.22
check-latest: true
cache: true
-
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
strategy:
fail-fast: true
matrix:
go: ["1.20", "1.19"]
go: [1.22.1]
name: go ${{ matrix.go }}
steps:
- name: Checkout
Expand Down Expand Up @@ -46,7 +46,7 @@ jobs:
- name: Setup go
uses: actions/setup-go@v4
with:
go-version: 1.19
go-version: 1.22
check-latest: true
cache: true

Expand Down
5 changes: 3 additions & 2 deletions .golangci.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
---
run:
go: "1.15"
go: "1.22"
linters:
disable-all: true
enable:
- bodyclose
- depguard
# https://github.com/atc0005/go-ci/issues/1024
# - depguard
- dogsled
- exhaustive
- funlen
Expand Down
241 changes: 122 additions & 119 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,210 +1,213 @@
# [Unreleased]

- Updated go version to 1.22.1 to fix 3 CVEs (#559, @dianadevasia)
- Updated the version of golangci to 1.56.2 and disabled depguard rule in golangci (#559, @dianadevasia)

# [2.8.0] - 2024-02-27

* toxiproxy-cli - sortedAttributes sort by attribute.key instead attribute.value (#543, @jesseward)
- toxiproxy-cli - sortedAttributes sort by attribute.key instead attribute.value (#543, @jesseward)

# [2.7.0] - 2023-10-25

* Fix invalid JSON in /version endpoint response (#538, @whatyouhide)
* Update minimum supported Go version 1.19. (@abecevello)
- Fix invalid JSON in /version endpoint response (#538, @whatyouhide)
- Update minimum supported Go version 1.19. (@abecevello)

# [2.6.0] - 2023-08-22

* Gracefull shutdown of HTTP server. (#439, @miry)
* Support PATCH HTTP method for Proxy update(`PATCH /proxies/{proxy}`) and
- Gracefull shutdown of HTTP server. (#439, @miry)
- Support PATCH HTTP method for Proxy update(`PATCH /proxies/{proxy}`) and
Toxic update(`PATCH /proxies/{proxy}/toxics/{toxic}`) endpoints.
Deprecat POST HTTP method for those endpoints. (@miry)
* Client does not parse response body in case of errors for Populate.
- Client does not parse response body in case of errors for Populate.
Requires to get current proxies with new command. (#441, @miry)
* Client specifies `User-Agent` HTTP header for all requests as
- Client specifies `User-Agent` HTTP header for all requests as
"toxiproxy-cli/<version> <os>/<runtime>".
Specifies client request content type as `application/json`. (#441, @miry)
* Replace Api.Listen parameters `host` and `port` with single `addr`. (#445, @miry)
- Replace Api.Listen parameters `host` and `port` with single `addr`. (#445, @miry)

# [2.5.0] - 2022-09-10

* Update Release steps. (#369, @neufeldtech)
* Migrate off probot-CLA to new GitHub Action. (#405, @cursedcoder)
* Support go 1.18, 1.19. (#415, @miry)
* `toxiproxy.NewProxy` now accepts `name`, `listen addr` and `upstream addr`. (#418, @miry)
* Replace logrus with zerolog. (#413, @miry)
* Log HTTP requests to API server. (#413, #421, @miry)
* Add TimeoutHandler for the HTTP API server. (#420, @miry)
* Set Write and Read timeouts for HTTP API server connections. (#423, @miry)
* Show unique request id in API HTTP response. (#425, @miry)
* Add method to parse `stream.Direction` from a string.
- Update Release steps. (#369, @neufeldtech)
- Migrate off probot-CLA to new GitHub Action. (#405, @cursedcoder)
- Support go 1.18, 1.19. (#415, @miry)
- `toxiproxy.NewProxy` now accepts `name`, `listen addr` and `upstream addr`. (#418, @miry)
- Replace logrus with zerolog. (#413, @miry)
- Log HTTP requests to API server. (#413, #421, @miry)
- Add TimeoutHandler for the HTTP API server. (#420, @miry)
- Set Write and Read timeouts for HTTP API server connections. (#423, @miry)
- Show unique request id in API HTTP response. (#425, @miry)
- Add method to parse `stream.Direction` from a string.
Allow converting `stream.Direction` to string. (#430, @miry)
* Add the possibility to write to Output with a deadline.
- Add the possibility to write to Output with a deadline.
On interrupting Bandwidth toxic, use non-blocking writes. (#436, @miry)
* Update minimum supported Go version 1.17. (#438, @miry)
- Update minimum supported Go version 1.17. (#438, @miry)

# [2.4.0] - 2022-03-07

* Verify git tag on release (#347, @miry)
* Fix MacOS 12 tests for go17 with -race flag (#351, @strech)
* Rename `testing/` and `bin/` folders (#354, @strech)
* Added verbose error on proxy upstream dialing (#355, @f-dg)
* Improve server startup message (#358, @areveny)
* Introduce yaml linter. (#362, @miry)
* Handle slicer toxic with zero `SizeVariation` and fix slicing randomization (#359, @areveny)
* Added /metrics endpoint for exposing Prometheus-compatible internal metrics (#366, @neufeldtech)
- Verify git tag on release (#347, @miry)
- Fix MacOS 12 tests for go17 with -race flag (#351, @strech)
- Rename `testing/` and `bin/` folders (#354, @strech)
- Added verbose error on proxy upstream dialing (#355, @f-dg)
- Improve server startup message (#358, @areveny)
- Introduce yaml linter. (#362, @miry)
- Handle slicer toxic with zero `SizeVariation` and fix slicing randomization (#359, @areveny)
- Added /metrics endpoint for exposing Prometheus-compatible internal metrics (#366, @neufeldtech)

# [2.3.0] - 2021-12-23

* Store all the executable `main` packages in `cmd` folder. (#335, @miry)
* Extract common test helpers to own files. (#336, @miry)
* Client: Allow HTTPS endpoints. (#338, @chen-anders)
* client.Populate assign client to proxy. (#291, @hellodudu)
* fix: The release-test task is always success.
- Store all the executable `main` packages in `cmd` folder. (#335, @miry)
- Extract common test helpers to own files. (#336, @miry)
- Client: Allow HTTPS endpoints. (#338, @chen-anders)
- client.Populate assign client to proxy. (#291, @hellodudu)
- fix: The release-test task is always success.
add: Allow to run release-test on arm machines. (#340, @miry)
* Upgrade `goreleaser`. Support `armv7` and `armv6` oses. (#339, @mitchellrj)
* Allow to change log level for server. (#346, @miry)
- Upgrade `goreleaser`. Support `armv7` and `armv6` oses. (#339, @mitchellrj)
- Allow to change log level for server. (#346, @miry)

# [2.2.0] - 2021-10-17

* Update linux packages to use `/usr/bin` folder as binary destination and change the executable names to
- Update linux packages to use `/usr/bin` folder as binary destination and change the executable names to
exclude ARCH and OS names. New pathes:
```
/usr/bin/toxiproxy-cli
/usr/bin/toxiproxy-server
```
(#331, @miry)
* A new toxic to simulate TCP RESET (Connection reset by peer) on the connections by closing
- A new toxic to simulate TCP RESET (Connection reset by peer) on the connections by closing
the stub Input immediately or after a timeout. (#247 and #333, @chaosbox)

# [2.1.7] - 2021-09-23

* Set the valid version during the build process.
- Set the valid version during the build process.
Verify the correct verion of the built binaries with `make release-dry` (#328, @miry)

# [2.1.6] - 2021-09-23

* Use CHANGELOG.md for release description (#306, @miry)
* Dependency updates in #294 introduced a breaking change in CLI argument parsing.
- Use CHANGELOG.md for release description (#306, @miry)
- Dependency updates in #294 introduced a breaking change in CLI argument parsing.
Now [flags must be specified before arguments](https://github.com/urfave/cli/blob/master/docs/migrate-v1-to-v2.md#flags-before-args).
Previously, arguments could be specified prior to flags.
Update usage help text and documentation. (#308, @miry)
* Run e2e tests to validate the command line and basic features of server,
- Run e2e tests to validate the command line and basic features of server,
client and application (#309, @miry)
* Add /v2 suffix to module import path (#311, @dnwe)
* Setup automated checking source code for security vulnerabilities (#312, @miry)
* Setup code linter (#314, @miry)
* Max line length is 100 characters (#316, @miry)
* Linter to check whether HTTP response body is closed successfully (#317, @miry)
* Make sure the function are not big (#318, @miry)
* Extract client flags specs to seprate methods.
- Add /v2 suffix to module import path (#311, @dnwe)
- Setup automated checking source code for security vulnerabilities (#312, @miry)
- Setup code linter (#314, @miry)
- Max line length is 100 characters (#316, @miry)
- Linter to check whether HTTP response body is closed successfully (#317, @miry)
- Make sure the function are not big (#318, @miry)
- Extract client flags specs to seprate methods.
Introduce a new way to manage toxics with `ToxicOptions` structure (#321, @miry)
* Split `Proxy.server` to multiple small (#322, @miry)
* Extract initializetion of fake upstream server to test helper (#323, @miry)
* Support a list of well knonwn linters (#326, @miry)
* `--host` flag uses `TOXIPROXY_URL` if it is set (#319, @maaslalani)
* Run benchmarks in CI/CD (#320, @miry)
* Use scratch docker base image instead of alpine (#325, @miry)
- Split `Proxy.server` to multiple small (#322, @miry)
- Extract initializetion of fake upstream server to test helper (#323, @miry)
- Support a list of well knonwn linters (#326, @miry)
- `--host` flag uses `TOXIPROXY_URL` if it is set (#319, @maaslalani)
- Run benchmarks in CI/CD (#320, @miry)
- Use scratch docker base image instead of alpine (#325, @miry)

# [2.1.5] - 2021-09-01

* Move to Go Modules from godeps (#253, @epk)
* Update the example in `client/README.md` (#251, @nothinux)
* Update TOC in `README.md` (4ca1eddddfcd0c50c8f6dfb97089bb68e6310fd9, @dwradcliffe)
* Add an example of `config.json` file to `README.md` (#260, @JesseEstum)
* Add Link to Elixir Client (#287, @Jcambass)
* Add Rust client link (#293, @itarato)
* Renovations: formatting code, update dependicies, make govet/staticcheck pass (#294, @dnwe)
* Remove `openssl` from `dev.yml` to use `dev` tool (#298, @pedro-stanaka)
* Update `go` versions in development (#299, @miry)
* Mention `MacPorts` in `README.md` (#290, @amake)
* Fix some typos in `README.md` and `CHANGELOG.md` (#222, @jwilk)
* Replace TravisCI with Github Actions to run tests (#303, @miry)
* Build and release binaries with `goreleaser`. Support `arm64` and BSD oses. (#301, @miry)
* Automate release with Github actions (#304, @miry)
- Move to Go Modules from godeps (#253, @epk)
- Update the example in `client/README.md` (#251, @nothinux)
- Update TOC in `README.md` (4ca1eddddfcd0c50c8f6dfb97089bb68e6310fd9, @dwradcliffe)
- Add an example of `config.json` file to `README.md` (#260, @JesseEstum)
- Add Link to Elixir Client (#287, @Jcambass)
- Add Rust client link (#293, @itarato)
- Renovations: formatting code, update dependicies, make govet/staticcheck pass (#294, @dnwe)
- Remove `openssl` from `dev.yml` to use `dev` tool (#298, @pedro-stanaka)
- Update `go` versions in development (#299, @miry)
- Mention `MacPorts` in `README.md` (#290, @amake)
- Fix some typos in `README.md` and `CHANGELOG.md` (#222, @jwilk)
- Replace TravisCI with Github Actions to run tests (#303, @miry)
- Build and release binaries with `goreleaser`. Support `arm64` and BSD oses. (#301, @miry)
- Automate release with Github actions (#304, @miry)

# [2.1.4] - 2019-01-11

* Bug fix: Fix OOM in toxic. #232
* Documentation updates.
* CI and test updates.
- Bug fix: Fix OOM in toxic. #232
- Documentation updates.
- CI and test updates.

# [2.1.3] - 2018-03-05

* Update `/version` endpoint to also return a charset of utf-8. #204
* Bug fix: Double http concatenation. #191
* Update cli examples to be more accurate. #187
- Update `/version` endpoint to also return a charset of utf-8. #204
- Bug fix: Double http concatenation. #191
- Update cli examples to be more accurate. #187

# [2.1.2] - 2017-07-10

* go 1.8, make Sirupsen lower case, update godeps (issue #179)
* Handle SIGTERM to exit cleanly (issue #180)
* Address security issue by disallowing browsers from accessing API
- go 1.8, make Sirupsen lower case, update godeps (issue #179)
- Handle SIGTERM to exit cleanly (issue #180)
- Address security issue by disallowing browsers from accessing API

# [2.1.1] - 2017-05-16

* Fix timeout toxic causing hang (issue #159)
- Fix timeout toxic causing hang (issue #159)

# [2.1.0] - 2016-12-07

* Add -config server option to populate on startup #154
* Updated CLI for scriptability #133
* Add `/populate` endpoint to server #111
* Change error responses from `title` to `error`
* Allow hostname to be specified in CLI #129
* Add support for stateful toxics #127
* Add limit_data toxic
- Add -config server option to populate on startup #154
- Updated CLI for scriptability #133
- Add `/populate` endpoint to server #111
- Change error responses from `title` to `error`
- Allow hostname to be specified in CLI #129
- Add support for stateful toxics #127
- Add limit_data toxic

# [2.0.0] - 2016-04-25

* Add CLI (`toxiproxy-cli`) and rename server binary to `toxiproxy-server` #93
* Fix removing a timeout toxic causing API to hang #89
* API and client return toxics as array rather than a map of name to toxic #92
* Fix multiple latency toxics not accumulating #94
* Change default toxic name to `<type>_<stream>` #96
* Nest toxic attributes rather than having a flat structure #98
* 2.0 RFC: #54 and PR #62
* Change toxic API endpoints to an Add/Update/Remove structure
* Remove `enabled` field, and add `name` and `type` fields to toxics
* Add global toxic fields to a wrapper struct
* Chain toxics together dynamically instead of in a fixed length chain
* Register toxics in `init()` functions instead of a hard-coded list
* Clean up API error codes to make them more consistent
* Move toxics to their own package to allow 3rd party toxics
* Remove stream direction from API urls #73
* Add `toxicity` field for toxics #75
* Refactor Go client to make usage easier with 2.0 #76
* Make `ChanReader` in the `stream` package interruptible #77
* Define proxy buffer sizes per-toxic (Fixes #72)
* Fix slicer toxic testing race condition #71
- Add CLI (`toxiproxy-cli`) and rename server binary to `toxiproxy-server` #93
- Fix removing a timeout toxic causing API to hang #89
- API and client return toxics as array rather than a map of name to toxic #92
- Fix multiple latency toxics not accumulating #94
- Change default toxic name to `<type>_<stream>` #96
- Nest toxic attributes rather than having a flat structure #98
- 2.0 RFC: #54 and PR #62
- Change toxic API endpoints to an Add/Update/Remove structure
- Remove `enabled` field, and add `name` and `type` fields to toxics
- Add global toxic fields to a wrapper struct
- Chain toxics together dynamically instead of in a fixed length chain
- Register toxics in `init()` functions instead of a hard-coded list
- Clean up API error codes to make them more consistent
- Move toxics to their own package to allow 3rd party toxics
- Remove stream direction from API urls #73
- Add `toxicity` field for toxics #75
- Refactor Go client to make usage easier with 2.0 #76
- Make `ChanReader` in the `stream` package interruptible #77
- Define proxy buffer sizes per-toxic (Fixes #72)
- Fix slicer toxic testing race condition #71

# [1.2.1] - 2015-07-24

* Fix proxy name conflicts leaking an open port #69
- Fix proxy name conflicts leaking an open port #69

# [1.2.0] - 2015-07-23

* Add a Toxic and Toxics type for the Go client
* Add `Dockerfile`
* Fix latency toxic limiting bandwidth #67
* Add Slicer toxic
- Add a Toxic and Toxics type for the Go client
- Add `Dockerfile`
- Fix latency toxic limiting bandwidth #67
- Add Slicer toxic

# [1.1.0] - 2015-05-05

* Remove /toxics endpoint in favour of /proxies
* Add bandwidth toxic
- Remove /toxics endpoint in favour of /proxies
- Add bandwidth toxic

# [1.0.3] - 2015-04-29

* Rename Go library package to Toxiproxy from Client
* Fix latency toxic send to closed channel panic #46
* Fix latency toxic accumulating delay #47
- Rename Go library package to Toxiproxy from Client
- Fix latency toxic send to closed channel panic #46
- Fix latency toxic accumulating delay #47

# [1.0.2] - 2015-04-12

* Added Toxic support to Go client
- Added Toxic support to Go client

# [1.0.1] - 2015-03-31

* Various improvements to the documentation
* Initial version of Go client
* Fix toxic disabling bug #42
- Various improvements to the documentation
- Initial version of Go client
- Fix toxic disabling bug #42

# [1.0.0] - 2015-01-07

Expand Down
Loading

0 comments on commit c2fedde

Please sign in to comment.