Theme Check: Issue of 0 files being inspected on Windows when using the CLI #322
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…windows machines due to '\' seperator being passed to glob.
|
I have signed the CLA! |
justshrey
changed the title
|
You are amazing. This was on my TODO list but couldn't get around doing it with everything else on there. Thank you! I'll add a changeset for a patch bump and see that this gets into the CLI ASAP. 🙏 |
charlespwd
approved these changes
Mar 11, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
Fixes Shopify/cli#3497
The main issue was that on windows, no liquid or json files were being selected despite
'**/*.{liquid,json}'as the glob function.this happens because in windows, the path separator output by path.join is '' which conflicts with the glob escape character.
To solve it, have normalized the path and just replaced '' with '/' . This should solve this since it wont have any impact on existing linux paths.
What's next? Any followup issues?
N/A -
What did you learn?