-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lint changes from a specific branch #97
base: adds-support-for-dev
Are you sure you want to change the base?
Conversation
fcec406
to
427e1fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a test on a non-master branch, e.g. where master passes the linter but non-master doesn't.
Fix typo in readme: compatible
Adds support for dev
@@ -79,7 +79,6 @@ def test_detects_changed_python_files(main_repo, python_file, python_script): | |||
main_repo.create_head('foo').checkout() | |||
main_repo.index.add([python_file, python_script]) | |||
main_repo.index.commit("adding python files") | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the deletion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good question. Gonna remove this
Description
Sometime your changes should not be compared with master but with a specific branch. This PR let you compare your changes with any branch,
master
by default.