Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint changes from a specific branch #97

Open
wants to merge 4 commits into
base: adds-support-for-dev
Choose a base branch
from

Conversation

mlhamel
Copy link
Contributor

@mlhamel mlhamel commented Apr 18, 2018

Description

Sometime your changes should not be compared with master but with a specific branch. This PR let you compare your changes with any branch, master by default.

@mlhamel mlhamel changed the base branch from master to adds-support-for-dev April 18, 2018 16:11
@mlhamel mlhamel requested a review from JasonMWhite April 18, 2018 16:11
@mlhamel mlhamel changed the title Lint with branch Lint changes from a specific branch Apr 18, 2018
@mlhamel mlhamel requested a review from shardulbee April 20, 2018 15:52
Copy link
Member

@JasonMWhite JasonMWhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a test on a non-master branch, e.g. where master passes the linter but non-master doesn't.

@@ -79,7 +79,6 @@ def test_detects_changed_python_files(main_repo, python_file, python_script):
main_repo.create_head('foo').checkout()
main_repo.index.add([python_file, python_script])
main_repo.index.commit("adding python files")

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the deletion?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question. Gonna remove this

@mlhamel mlhamel force-pushed the lint-with-branch branch from 427e1fd to 3f5090f Compare May 16, 2018 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants