Add unary operators and resilience against unrecognized operators #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfournie
reviewed
Jun 5, 2017
| @@ -295,10 +298,20 @@ def __lambda_func(self, node): # type: (astroid.Lambda) -> None | |||
| elif isinstance(node.body, astroid.BinOp): | |||
| if shopify_python.ast.count_tree_size(node.body) == 3 and len(node.args.args) == 2: | |||
| node = node.body | |||
| operator = self.BINARY_OPERATORS[node.op] | |||
| operator = self.BINARY_OPERATORS.get(node.op, None) | |||
There was a problem hiding this comment.
I'm not sure how to test this while implementing all operators.
There was a problem hiding this comment.
It is in fact covered by https://github.com/Shopify/shopify_python/pull/74/files#diff-91e31ad8c2d48b1c0d10cce924bc746eR293
cfournie
approved these changes
Jun 5, 2017
cfournie
reviewed
Jun 5, 2017
| unary_root = astroid.builder.parse(""" | ||
| def unaryfnc(): | ||
| unary_fail = map(lambda x: {}, [1, 2, 3, 4]) | ||
| """.format(expression)) |
There was a problem hiding this comment.
These changes appear to be built upon #73; I assume that you'll rebase before merging.
There was a problem hiding this comment.
My apologies, forgot to set the base branch. It's updated now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cfournie PTAL. Solves the following:
This change is