-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] bump pylint #115
base: master
Are you sure you want to change the base?
[WIP] bump pylint #115
Conversation
Another, lower impact option would be to somehow lock the version of |
@@ -1,4 +1,4 @@ | |||
# pylint: disable=missing-docstring,deprecated-lambda |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://docs.pylint.org/en/1.6.0/features.html
"This message can’t be emitted when using Python >= 3.0."
Alternatively, we can include a lambda_func.rc
file with
[testoptions]
max_pyver=3.0
Any change we can merge this? My PR is failing because it needs |
You could potentially make a branch in this repo, make the fixes you need, then reference the branch name using a suffix in your setuptools or pip requirements.txt, e.g.
|
I am also seeing this issue in another repo. Is it possible to ship this change to |
Problem summary:
Currently shopify_python requires pylint ~= 2.1.1. But,
pylint
v2.1.* has this dependency issue on'isort >= 4.2.5
. There's no dependency constraint there, so eventuallyisort
releasedv5
. pylint 2.1.1 picks up the new version and breaks.More recently,
pylint 2.6.0
supportsisort v5
pylint-dev/pylint#3725This PR relaxes the dependency constraint so
shopify_python
will pick up the newerpylint
version.This PR fixes #114
I tested this by:
[ ] pytest locally
[ ] push to PyPi test and test fix downstream in Panama CI