Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] bump pylint #115

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[WIP] bump pylint #115

wants to merge 4 commits into from

Conversation

DavidGarfinkle
Copy link

@DavidGarfinkle DavidGarfinkle commented Dec 9, 2020

Problem summary:

Currently shopify_python requires pylint ~= 2.1.1. But, pylint v2.1.* has this dependency issue on 'isort >= 4.2.5. There's no dependency constraint there, so eventually isort released v5. pylint 2.1.1 picks up the new version and breaks.

More recently, pylint 2.6.0 supports isort v5 pylint-dev/pylint#3725

This PR relaxes the dependency constraint so shopify_python will pick up the newer pylint version.

This PR fixes #114

I tested this by:
[ ] pytest locally
[ ] push to PyPi test and test fix downstream in Panama CI

@erikwright
Copy link
Contributor

Another, lower impact option would be to somehow lock the version of isort?

@@ -1,4 +1,4 @@
# pylint: disable=missing-docstring,deprecated-lambda
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.pylint.org/en/1.6.0/features.html
"This message can’t be emitted when using Python >= 3.0."

Alternatively, we can include a lambda_func.rc file with

[testoptions]
max_pyver=3.0

@jessicaxiejw
Copy link

Any change we can merge this? My PR is failing because it needs pylint > 2.3.0 https://github.com/Shopify/ci-queue/pull/168/checks?check_run_id=2271709639

see: conda-forge/pylint-feedstock#29 (comment)

@efung
Copy link

efung commented Apr 6, 2021

Any change we can merge this? My PR is failing because it needs pylint > 2.3.0 https://github.com/Shopify/ci-queue/pull/168/checks?check_run_id=2271709639

You could potentially make a branch in this repo, make the fixes you need, then reference the branch name using a suffix in your setuptools or pip requirements.txt, e.g.

git+https://github.com/Shopify/shopify_python.git@your-example-branch

@jordansmithnl
Copy link

Any change we can merge this? My PR is failing because it needs pylint > 2.3.0 https://github.com/Shopify/ci-queue/pull/168/checks?check_run_id=2271709639

see: conda-forge/pylint-feedstock#29 (comment)

I am also seeing this issue in another repo. Is it possible to ship this change to shopify_python?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pylint ~= 2.1.1 is broken on isort v5
5 participants