Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pylint ~= 2.1.1 is broken on isort v5 #114

Open
DavidGarfinkle opened this issue Dec 9, 2020 · 0 comments · May be fixed by #115
Open

Pylint ~= 2.1.1 is broken on isort v5 #114

DavidGarfinkle opened this issue Dec 9, 2020 · 0 comments · May be fixed by #115
Assignees

Comments

@DavidGarfinkle
Copy link

DavidGarfinkle commented Dec 9, 2020

I'm opening this issue because https://github.com/shopify/panama python client depends on shopify_python and there's a dependency issue on pylint v2.1.1 that I think needs to be fixed here

Currently shopify_python requires pylint ~= 2.1.1. But, pylint v2.1.1 has this dependency issue on 'isort >= 4.2.5. There's no dependency constraint there, so eventually isort released v5. pylint 2.1.1 picks up the new version and breaks.

pylint fixed this by pinning their dependencies, like isort>=4.2.5,<5

More recently, pylint 2.6.0 supports isort v5 pylint-dev/pylint#3725

Let's upgrade pylint to the newest version and use a compatible release on major version rather than minor

i.e., pylint ~= 2.1 as opposed to pylint ~= 2.1.1

@DavidGarfinkle DavidGarfinkle self-assigned this Dec 9, 2020
@DavidGarfinkle DavidGarfinkle linked a pull request Dec 9, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant