Only write color YJIT disassembly escape codes in a tty #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would like to pre-emptively call out that I am new to Rust and new to this project. I am welcome to any & all feedback, especially with explanations about why you might do something differently. |
tekknolagi
force-pushed
the
mb-only-color-tty
branch
from
7d35171 to
594648a
Compare
tekknolagi
force-pushed
the
mb-only-color-tty
branch
from
594648a to
4544402
Compare
|
Misunderstood instructions; instead filed ruby#12283 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces noise when piping to a file.