Pluralize issues with patterns #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLURALIZE_PATTERNSinutils.pyhave multiple issues:group unmatchederrorIssue 1. is pretty obvious, forgotten slash here:
(r'(hive)$', r'1s').Issue 2. will happen with Python versions below 3.5 because of the following issue:
Unmatched Group issue - workaround
I'm no expert on regex, unfortunately, so I just split offending pattern in two separate. That seems to fix the issue but adds duplicity. Anyone more experienced might try to find a better solution.
I added tests and run on Python 2.7.
Please let me know if there are any problems with this pull request or point me to some docs for contributors. Thank you.