Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix outline on textfield focus #11989

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix outline on textfield focus #11989

wants to merge 1 commit into from

Conversation

nandinicbit1981
Copy link

@nandinicbit1981 nandinicbit1981 commented May 8, 2024 •
edited

WHY are these changes introduced?

Fixes https://github.com/Shopify/mobile/issues/32112

Text field shows 2 borders on focus.

WHAT is this pull request doing?

This PR fixes hides the border on focus and just displays the outline. Also, changes the cursor color.

How to 馃帺

  • Go to storybook
  • In storybook navigate to textfield and ensure seeing only outline on the text field
  • Confirm only outline is displayed on the text field on focus
  • Confirm cursor color is blue on focus on text field
Before After
IMG_4156 IMG_4157
RPReplay_Final1715137312.MP4

馃帺 checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@nandinicbit1981